Review Request 122398: Actions QuickOpen backend

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122398/#review75288
-----------------------------------------------------------


nice - this already goes a long shot towards my idea (which I never got around to implement). Show the rest of the code, but I'd say this is already a +1 from the conceptual side.


plugins/quickopen/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122398/#comment52072>

    this file is missing :)



plugins/quickopen/quickopenplugin.h
<https://git.reviewboard.kde.org/r/122398/#comment52074>

    QScopedPointer and remove the explicit delete



plugins/quickopen/quickopenplugin.cpp
<https://git.reviewboard.kde.org/r/122398/#comment52073>

    we need any scope here, right? sounds odd to have actions of includes, but it's OK if this makes it work.


- Milian Wolff


On Feb. 3, 2015, 1:26 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122398/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 1:26 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I wanted to look into this for longtime, only ended up doing so yesterday when flying home from FOSDEM.
> 
> The idea is simple, we love Quick Open, we get actions on the Quick Open.
> I see it as an approach to what Milian wanted to look into, of having a console to run KDevelop, I think that this with some development could end up quite close. For now, it's already somewhat useful.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/CMakeLists.txt 90e1efd 
>   plugins/quickopen/quickopenplugin.h 829e0ab 
>   plugins/quickopen/quickopenplugin.cpp 75ee422 
> 
> Diff: https://git.reviewboard.kde.org/r/122398/diff/
> 
> 
> Testing
> -------
> 
> I played around with it for a while.
> 
> 
> File Attachments
> ----------------
> 
> quickopen-actions.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/b94711e0-837b-42a1-bbee-75b42b797cd9__quickopen-actions.png
> quickopen-actions1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/5665a6bd-7df6-4121-89ab-c12c4a0ebf30__quickopen-actions1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150203/c094a500/attachment-0001.html>