Review Request 124745: Always attach AST to the active document

Sergey Kalinichev kalinichev.so.0 at gmail.com
Fri Aug 21 08:54:40 UTC 2015



> On Aug. 20, 2015, 8:13 p.m., Milian Wolff wrote:
> > clangsupport.cpp, line 392
> > <https://git.reviewboard.kde.org/r/124745/diff/2/?file=396593#file396593line392>
> >
> >     this is wrong, no? it will return a context for a different url, or am I mistaken?
> >     
> >     Q_ASSERT(context->url() == url)
> >     
> >     does this work with this patch?

Ah, I think I finally get it. The purpose of this TU pinning is to use includes/defines from source file when parsing a header file and also to find the attached AST. If that's the case, then yes, what I'm doing here is completely wrong.

My bad, I didn't fully understand how this TU pinning stuff works. Fixing it now.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124745/#review84096
-----------------------------------------------------------


On Aug. 20, 2015, 11:32 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124745/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 11:32 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This should fix the issue when we had no code completion after restoring context from disk, if the active document wasn't modified beforehand.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.h ba2d5ac 
>   clangparsejob.cpp a80433e 
>   clangsupport.h a047382 
>   clangsupport.cpp 22b6c96 
>   codecompletion/model.cpp 57902d3 
>   tests/test_duchain.h 694f5a2 
>   tests/test_duchain.cpp 796e3c6 
> 
> Diff: https://git.reviewboard.kde.org/r/124745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150821/685acd42/attachment.html>


More information about the KDevelop-devel mailing list