Review Request 124745: Always attach AST to the active document

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124745/#review84096
-----------------------------------------------------------



clangparsejob.cpp (line 158)
<https://git.reviewboard.kde.org/r/124745/#comment58235>

    I dislike this approach. Rather remove your change in the support class and add a util function that takes a fileUrl + tuUrl and looks for both ctx and then takes either ParseSessionData.



clangparsejob.cpp (line 252)
<https://git.reviewboard.kde.org/r/124745/#comment58231>

    it should still return here, no?



clangsupport.cpp (line 239)
<https://git.reviewboard.kde.org/r/124745/#comment58232>

    split into two lines please, before the "this".



clangsupport.cpp (line 392)
<https://git.reviewboard.kde.org/r/124745/#comment58233>

    this is wrong, no? it will return a context for a different url, or am I mistaken?
    
    Q_ASSERT(context->url() == url)
    
    does this work with this patch?



codecompletion/model.cpp (line 107)
<https://git.reviewboard.kde.org/r/124745/#comment58234>

    either remove it, or don't - but don't add such a comment.


- Milian Wolff


On Aug. 20, 2015, 8:32 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124745/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 8:32 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This should fix the issue when we had no code completion after restoring context from disk, if the active document wasn't modified beforehand.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.h ba2d5ac 
>   clangparsejob.cpp a80433e 
>   clangsupport.h a047382 
>   clangsupport.cpp 22b6c96 
>   codecompletion/model.cpp 57902d3 
>   tests/test_duchain.h 694f5a2 
>   tests/test_duchain.cpp 796e3c6 
> 
> Diff: https://git.reviewboard.kde.org/r/124745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150820/18c8a020/attachment-0001.html>