Review Request 124677: Make static refactoring

[Maciej Poleski]

> On Sie 10, 2015, 9:16 po południu, Milian Wolff wrote:
> > could you please also spent some time documentating the API you write and have written? e.g. the classes and functions for refactoring should get code examples to show what they do. you did that in one place, but not the other:

Yes. I also want to write some general document on architecture and in general "what we have" and "what we can have" (what is Clang in libTooling in general with respect to IDE)


> On Sie 10, 2015, 9:16 po południu, Milian Wolff wrote:
> > refactoring/movefunctionrefactoring.cpp, line 34
> > <https://git.reviewboard.kde.org/r/124677/diff/1/?file=391446#file391446line34>
> >
> >     here, and elsewhere if you've done that previously and I haven't spotted it:
> >     
> >     please push this documentation into the header, and put it into `/** ... */` doxygen blocks

well, it is only sketch of idea - not to forget later about arrangement. I don't consider this well formed documentation.
I'll spend some time makeing real documentation (but first I want to finish this feature and also a few more small improvements elsewhere)


> On Sie 10, 2015, 9:16 po południu, Milian Wolff wrote:
> > tests/test_instancetostatic.cpp, line 76
> > <https://git.reviewboard.kde.org/r/124677/diff/1/?file=391452#file391452line76>
> >
> >     this looks identical to above, except for the "static" in front of the "int f" - is that really all this action does? where is myName being used, why does it need to be passed?

difference is that one method uses "this" (because acces to instance field) and the other does not. If no such use exist then "transformation" does not intruduce new parameter and does not transform implementation to use new parameter instead of "this". If "this" is used - new parameter is introduced and implementation changed appropriately (also on calls to that function).

"myName" is a name for additional argument. It is used only if neccessary (if not used, GUI will not appear and empty string is passed). Name matters only if really needed.


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124677/#review83668
-----------------------------------------------------------


On Sie 10, 2015, 12:55 rano, Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124677/
> -----------------------------------------------------------
> 
> (Updated Sie 10, 2015, 12:55 rano)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Make static refactoring + tests
> 
> This is not local refactoring... Only two of https://techbase.kde.org/Projects/kdev-clang/RefactoringTools#Ideas_for_Refactoring_Tools was "local". But idea of "move" look nice. There is also stub for "move", make static is a prerequirement
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/instancetostaticrefactoring.h PRE-CREATION 
>   refactoring/instancetostaticrefactoring.cpp PRE-CREATION 
>   refactoring/movefunctionrefactoring.h PRE-CREATION 
>   refactoring/movefunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/test_instancetostatic.h PRE-CREATION 
>   tests/test_instancetostatic.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124677/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150810/2f2fbd1d/attachment.html>