Review Request 124677: Make static refactoring

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124677/#review83668
-----------------------------------------------------------


could you please also spent some time documentating the API you write and have written? e.g. the classes and functions for refactoring should get code examples to show what they do. you did that in one place, but not the other:


refactoring/movefunctionrefactoring.cpp (line 34)
<https://git.reviewboard.kde.org/r/124677/#comment57902>

    here, and elsewhere if you've done that previously and I haven't spotted it:
    
    please push this documentation into the header, and put it into `/** ... */` doxygen blocks



tests/test_instancetostatic.cpp (line 76)
<https://git.reviewboard.kde.org/r/124677/#comment57901>

    this looks identical to above, except for the "static" in front of the "int f" - is that really all this action does? where is myName being used, why does it need to be passed?


- Milian Wolff


On Aug. 9, 2015, 10:55 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124677/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 10:55 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Make static refactoring + tests
> 
> This is not local refactoring... Only two of https://techbase.kde.org/Projects/kdev-clang/RefactoringTools#Ideas_for_Refactoring_Tools was "local". But idea of "move" look nice. There is also stub for "move", make static is a prerequirement
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/instancetostaticrefactoring.h PRE-CREATION 
>   refactoring/instancetostaticrefactoring.cpp PRE-CREATION 
>   refactoring/movefunctionrefactoring.h PRE-CREATION 
>   refactoring/movefunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/test_instancetostatic.h PRE-CREATION 
>   tests/test_instancetostatic.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124677/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150810/faccae0d/attachment.html>