Review Request 124502: This patch moves the class browser plugin's classmodel classes to libKDevPlatformLanguage.

[Sandro Andrade]

> On July 31, 2015, 10:05 a.m., Aleix Pol Gonzalez wrote:
> > plugins/classbrowser/classmodel.cpp, line 30
> > <https://git.reviewboard.kde.org/r/124502/diff/3/?file=388365#file388365line30>
> >
> >     Why did you change those?
> 
> Sandro Andrade wrote:
>     All classes which include other ones from the same library use relative paths for doing so. Since classmodel's classes are now part of the library it would make sense use the same approach, wouldn't it?
> 
> Aleix Pol Gonzalez wrote:
>     Well, I'm unsure. This is not how it was designed, but if that's how the rest are doing it, do it like them and we can fix it all at once eventually.

Anything else to enhance in this patch?


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124502/#review83234
-----------------------------------------------------------


On July 28, 2015, 8:26 a.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124502/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 8:26 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch moves the class browser plugin's classmodel classes to libKDevPlatformLanguage. The reason is to allow such code to be reused by plugins that require information about the project's namespaces, classes, and methods. The kdev-bundled-tree-view plugin needs that information for implementing its visualization features.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 2c2b028 
>   plugins/classbrowser/CMakeLists.txt 9989a4c 
>   plugins/classbrowser/allclassesfolder.h 48544d2 
>   plugins/classbrowser/allclassesfolder.cpp 6b40a44 
>   plugins/classbrowser/classbrowserplugin.cpp 140ed7d 
>   plugins/classbrowser/classmodel.h c6f0d3a 
>   plugins/classbrowser/classmodel.cpp 4aff279 
>   plugins/classbrowser/classmodelnode.h b8c038c 
>   plugins/classbrowser/classmodelnode.cpp 5f8e449 
>   plugins/classbrowser/classmodelnodescontroller.h c139465 
>   plugins/classbrowser/classmodelnodescontroller.cpp a51baa2 
>   plugins/classbrowser/classtree.cpp c173e09 
>   plugins/classbrowser/classwidget.cpp 53d09ab 
>   plugins/classbrowser/documentclassesfolder.h 3fd30a4 
>   plugins/classbrowser/documentclassesfolder.cpp e05e365 
>   plugins/classbrowser/projectfolder.h accb9a6 
>   plugins/classbrowser/projectfolder.cpp 26834c1 
> 
> Diff: https://git.reviewboard.kde.org/r/124502/diff/
> 
> 
> Testing
> -------
> 
> It builds fine and everything looks similar as before when using the class browser plugin.
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150806/1899d407/attachment.html>