<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124502/">https://git.reviewboard.kde.org/r/124502/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 31st, 2015, 10:05 a.m. BRT, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124502/diff/3/?file=388365#file388365line30" style="color: black; font-weight: bold; text-decoration: underline;">language/classmodel/classmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <span class="hl"><</span>interfaces/icore.h<span class="hl">></span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <span class="hl">"../../</span>interfaces/icore.h<span class="hl">"</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why did you change those?</p></pre>
</blockquote>
<p>On August 4th, 2015, 5:28 p.m. BRT, <b>Sandro Andrade</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All classes which include other ones from the same library use relative paths for doing so. Since classmodel's classes are now part of the library it would make sense use the same approach, wouldn't it?</p></pre>
</blockquote>
<p>On August 5th, 2015, 8:54 a.m. BRT, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, I'm unsure. This is not how it was designed, but if that's how the rest are doing it, do it like them and we can fix it all at once eventually.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anything else to enhance in this patch?</p></pre>
<br />
<p>- Sandro</p>
<br />
<p>On July 28th, 2015, 8:26 a.m. BRT, Sandro Andrade wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sandro Andrade.</div>
<p style="color: grey;"><i>Updated July 28, 2015, 8:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch moves the class browser plugin's classmodel classes to libKDevPlatformLanguage. The reason is to allow such code to be reused by plugins that require information about the project's namespaces, classes, and methods. The kdev-bundled-tree-view plugin needs that information for implementing its visualization features.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds fine and everything looks similar as before when using the class browser plugin.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/CMakeLists.txt <span style="color: grey">(2c2b028)</span></li>
<li>plugins/classbrowser/CMakeLists.txt <span style="color: grey">(9989a4c)</span></li>
<li>plugins/classbrowser/allclassesfolder.h <span style="color: grey">(48544d2)</span></li>
<li>plugins/classbrowser/allclassesfolder.cpp <span style="color: grey">(6b40a44)</span></li>
<li>plugins/classbrowser/classbrowserplugin.cpp <span style="color: grey">(140ed7d)</span></li>
<li>plugins/classbrowser/classmodel.h <span style="color: grey">(c6f0d3a)</span></li>
<li>plugins/classbrowser/classmodel.cpp <span style="color: grey">(4aff279)</span></li>
<li>plugins/classbrowser/classmodelnode.h <span style="color: grey">(b8c038c)</span></li>
<li>plugins/classbrowser/classmodelnode.cpp <span style="color: grey">(5f8e449)</span></li>
<li>plugins/classbrowser/classmodelnodescontroller.h <span style="color: grey">(c139465)</span></li>
<li>plugins/classbrowser/classmodelnodescontroller.cpp <span style="color: grey">(a51baa2)</span></li>
<li>plugins/classbrowser/classtree.cpp <span style="color: grey">(c173e09)</span></li>
<li>plugins/classbrowser/classwidget.cpp <span style="color: grey">(53d09ab)</span></li>
<li>plugins/classbrowser/documentclassesfolder.h <span style="color: grey">(3fd30a4)</span></li>
<li>plugins/classbrowser/documentclassesfolder.cpp <span style="color: grey">(e05e365)</span></li>
<li>plugins/classbrowser/projectfolder.h <span style="color: grey">(accb9a6)</span></li>
<li>plugins/classbrowser/projectfolder.cpp <span style="color: grey">(26834c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124502/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>