Review Request 124624: Extract function refactoring

[Aleix Pol Gonzalez]

> On Aug. 5, 2015, 3:47 p.m., Aleix Pol Gonzalez wrote:
> > Looks simple enough, can we get a test? :D
> 
> Maciej Poleski wrote:
>     Yes we can. I've just got an idea how to do that (how to reasonably mock GUI). It also applies to extract variable refactoring.
>     I had a blackout. More changes are coming

Why the gui? We can just test it at the functionality level, it's not too important to test the UI parts... IMHO


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124624/#review83460
-----------------------------------------------------------


On Aug. 5, 2015, 2:06 a.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124624/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 2:06 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract function (from expression) refactoring
> 
> Unfinished (one FIXME and one TODO, but these are small changes).
> 
> This refactoring extracts function from expression. More advanced version would also allow extracting from statements (but have to handle input _and_ __output__ variables).
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/extractfunctionrefactoring.h PRE-CREATION 
>   refactoring/extractfunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124624/diff/
> 
> 
> Testing
> -------
> 
> Manual testing (produces invalid code because of FIXME)
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150805/53e98fdd/attachment.html>