Review Request 124624: Extract function refactoring
Maciej Poleski
d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Wed Aug 5 16:21:43 UTC 2015
> On Sie 5, 2015, 3:47 po poĊudniu, Aleix Pol Gonzalez wrote:
> > Looks simple enough, can we get a test? :D
Yes we can. I've just got an idea how to do that (how to reasonably mock GUI). It also applies to extract variable refactoring.
I had a blackout. More changes are coming
- Maciej
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124624/#review83460
-----------------------------------------------------------
On Sie 5, 2015, 2:06 rano, Maciej Poleski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124624/
> -----------------------------------------------------------
>
> (Updated Sie 5, 2015, 2:06 rano)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> Extract function (from expression) refactoring
>
> Unfinished (one FIXME and one TODO, but these are small changes).
>
> This refactoring extracts function from expression. More advanced version would also allow extracting from statements (but have to handle input _and_ __output__ variables).
>
>
> Diffs
> -----
>
> refactoring/CMakeLists.txt PRE-CREATION
> refactoring/extractfunctionrefactoring.h PRE-CREATION
> refactoring/extractfunctionrefactoring.cpp PRE-CREATION
> refactoring/refactoringmanager.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124624/diff/
>
>
> Testing
> -------
>
> Manual testing (produces invalid code because of FIXME)
>
>
> Thanks,
>
> Maciej Poleski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150805/70bd9f43/attachment-0001.html>
More information about the KDevelop-devel
mailing list