Review Request 123279: Add color tab feature

Sebastien Speierer sspeiere at andrew.cmu.edu
Wed Apr 29 20:17:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/
-----------------------------------------------------------

(Updated April 29, 2015, 8:17 p.m.)


Review request for KDevelop.


Changes
-------

In this last patch I cleaned the code and applied all the modifications asked in the reviews.

This is hopefully the last changes for this feature.


Repository: kdevplatform


Description
-------

This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
This feature was asked by several users on the KDE bugtracking system.


Diffs (updated)
-----

  interfaces/iprojectcontroller.h 86c2dfd 
  plugins/projectmanagerview/projectmodelitemdelegate.cpp 69fd6c4 
  plugins/projectmanagerview/projecttreeview.h 6512157 
  plugins/projectmanagerview/projecttreeview.cpp dbd25ff 
  shell/mainwindow.h ae22648 
  shell/mainwindow.cpp 8757942 
  shell/plugincontroller.cpp 362bfb0 
  shell/projectcontroller.h 062e200 
  shell/projectcontroller.cpp 50bdce4 
  shell/settings/uiconfig.kcfg b168294 
  shell/settings/uiconfig.ui a0d76de 
  shell/uicontroller.cpp 2108ff2 
  sublime/container.h 9049f55 
  sublime/container.cpp 4444077 

Diff: https://git.reviewboard.kde.org/r/123279/diff/


Testing
-------

I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.


File Attachments (updated)
----------------

Screenshot01
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/c544c7ee-765e-4851-be5c-86d5b2241dab__kdevelop5_env_1.png
Screenshot #2 project_manager
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/79fa321d-3952-43d7-83e8-4af07116c82f__kdevelop5_env_2.png
Dark scheme color handled
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/8125d1e3-fb1d-4268-a100-c47523b9aa8e__kdevelop5_env_3.png


Thanks,

Sebastien Speierer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150429/6f96d58f/attachment-0001.html>


More information about the KDevelop-devel mailing list