Review Request 122898: port kdev-control-graph to kf5

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122898/#review78724
-----------------------------------------------------------

Ship it!



duchaincontrolflowinternaljob.h (line 32)
<https://git.reviewboard.kde.org/r/122898/#comment53865>

    Remove superfluos WS (3x)



duchaincontrolflowinternaljob.h (line 45)
<https://git.reviewboard.kde.org/r/122898/#comment53866>

    Use 'override' keyword


LGTM

- Kevin Funk


On March 11, 2015, 2:03 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122898/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 2:03 a.m.)
> 
> 
> Review request for KDevelop and Sandro Andrade.
> 
> 
> Repository: kdev-control-flow-graph
> 
> 
> Description
> -------
> 
> quick and dirty port
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bf65ed3 
>   controlflowgraphfiledialog.h 51217d6 
>   controlflowgraphfiledialog.cpp f790efd 
>   controlflowgraphnavigationcontext.cpp 8bf1d21 
>   controlflowgraphview.cpp 0a9ba01 
>   duchaincontrolflow.h 69d5eec 
>   duchaincontrolflow.cpp d94f55d 
>   duchaincontrolflowinternaljob.h ffb6da5 
>   duchaincontrolflowinternaljob.cpp 67132a5 
>   duchaincontrolflowjob.h 756c600 
>   duchaincontrolflowjob.cpp 158e6f6 
>   kdevcontrolflowgraphview.desktop.cmake 27b94d0 
>   kdevcontrolflowgraphview.json PRE-CREATION 
>   kdevcontrolflowgraphviewplugin.cpp 44cc60d 
> 
> Diff: https://git.reviewboard.kde.org/r/122898/diff/
> 
> 
> Testing
> -------
> 
> used it, together with the kgraphview port in the other review request.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150409/95919fe0/attachment.html>