Review Request 123279: Add color tab feature
Sebastien Speierer
sspeiere at andrew.cmu.edu
Wed Apr 22 22:11:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/
-----------------------------------------------------------
(Updated April 22, 2015, 10:11 p.m.)
Review request for KDevelop.
Changes
-------
The Color tab feature is now implemented in the shell (rather than in sublime) and I added a small API to Sublime::container to allow the shell to change tab colors.
The color assign to the project are now generated by a "hash algorithm" such that a same project would always have the same color.
I still cannot find the "color scheme" of the IDE so simply return black (hardcoded) when the feature is disable. If someone can explain me how to get this scheme color I can quickly change that.
In order to help the user associate the color to the different projects, I am planning to modify the project manager plug-in such that it colors the project names in the tree with the corresponding colors.
Repository: kdevplatform
Description
-------
This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
This feature was asked by several users on the KDE bugtracking system.
Diffs (updated)
-----
.kateproject.d/notes.txt PRE-CREATION
shell/mainwindow.h ae22648
shell/mainwindow.cpp 8757942
shell/project.cpp e7e6efa
shell/settings/uiconfig.kcfg b168294
shell/settings/uiconfig.ui a0d76de
shell/uicontroller.cpp 2108ff2
sublime/container.h 9049f55
sublime/container.cpp 4444077
sublime/urldocument.h 4a02d89
Diff: https://git.reviewboard.kde.org/r/123279/diff/
Testing
-------
I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.
Thanks,
Sebastien Speierer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150422/e58d3aa7/attachment.html>
More information about the KDevelop-devel
mailing list