Review Request 123279: Add color tab feature
Kevin Funk
kfunk at kde.org
Tue Apr 7 08:18:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/#review78596
-----------------------------------------------------------
Without looking at the diff:
- Do you have a screenshot?
- I'm fine with making this feature configurable (we've had multiple people already complaining about "too colorful variable names". @Aleix: Why so averse of options? :)
- Kevin Funk
On April 6, 2015, 6:34 p.m., Sebastien Speierer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123279/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 6:34 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
> This feature was asked by several users on the KDE bugtracking system.
>
>
> Diffs
> -----
>
> shell/settings/uiconfig.kcfg b168294d6e82049d25864f5153f362d568acf36b
> shell/settings/uiconfig.ui a0d76de6d7094d402dc10d836257f42f0a72d07a
> sublime/container.h 9049f558a7af172411539508a3db9bd708db6ace
> sublime/container.cpp 4444077efe28570f04c09605226327112034854b
> sublime/mainwindow.cpp 32ef797eec0a6d54b868615fddfb9be5ec4574ce
> sublime/urldocument.h 4a02d898e9ebb3d11a0efd43142d22e2bdea1a9d
>
> Diff: https://git.reviewboard.kde.org/r/123279/diff/
>
>
> Testing
> -------
>
> I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.
>
>
> Thanks,
>
> Sebastien Speierer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150407/e6a0fedc/attachment-0001.html>
More information about the KDevelop-devel
mailing list