Review Request 123279: Add color tab feature

[Sven Brauch]

> On April 6, 2015, 11:57 p.m., Andreas Pakulat wrote:
> > sublime/container.cpp, line 497
> > <https://git.reviewboard.kde.org/r/123279/diff/1/?file=360323#file360323line497>
> >
> >     What if my color scheme's text color isn't black? This should retrieve the existing tab text color and return that IMO.
> 
> Sebastien Speierer wrote:
>     I hardcoded this "default" color since I haven't found any color scheme concerning the KDevelop UI text color. What would be the best implementation? I could get the tabbar font color knowing that it is black by deflaut but I am not sure that it would be the best implementation. Any ideas?

In this case, you could just return an invalid QColor and not make the call to change the color at all if it's invalid.
But I agree, you should handle the case that the user has a non-grey background color for the tabs somehow, or it will end up unreadable for some users.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/#review78582
-----------------------------------------------------------


On April 6, 2015, 6:34 p.m., Sebastien Speierer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123279/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 6:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
> This feature was asked by several users on the KDE bugtracking system.
> 
> 
> Diffs
> -----
> 
>   shell/settings/uiconfig.kcfg b168294d6e82049d25864f5153f362d568acf36b 
>   shell/settings/uiconfig.ui a0d76de6d7094d402dc10d836257f42f0a72d07a 
>   sublime/container.h 9049f558a7af172411539508a3db9bd708db6ace 
>   sublime/container.cpp 4444077efe28570f04c09605226327112034854b 
>   sublime/mainwindow.cpp 32ef797eec0a6d54b868615fddfb9be5ec4574ce 
>   sublime/urldocument.h 4a02d898e9ebb3d11a0efd43142d22e2bdea1a9d 
> 
> Diff: https://git.reviewboard.kde.org/r/123279/diff/
> 
> 
> Testing
> -------
> 
> I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.
> 
> 
> Thanks,
> 
> Sebastien Speierer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150420/84166352/attachment.html>