Review Request 123279: Add color tab feature

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/#review78583
-----------------------------------------------------------


One more thing I just thought of: How do you imagine a user to make the connection between the coloring and the project(s)? Since the project entry in the project tree has no coloring its not immediately clear why the tabs get different colors or what the scheme is behind the coloring. So I think a hint which color is being assigned to which project would be good, especially so since you also re-shuffle the colors at least on restart based on the opening-order of tabs (no idea wether thats defined in any way).

- Andreas Pakulat


On April 6, 2015, 6:34 p.m., Sebastien Speierer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123279/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 6:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
> This feature was asked by several users on the KDE bugtracking system.
> 
> 
> Diffs
> -----
> 
>   shell/settings/uiconfig.kcfg b168294d6e82049d25864f5153f362d568acf36b 
>   shell/settings/uiconfig.ui a0d76de6d7094d402dc10d836257f42f0a72d07a 
>   sublime/container.h 9049f558a7af172411539508a3db9bd708db6ace 
>   sublime/container.cpp 4444077efe28570f04c09605226327112034854b 
>   sublime/mainwindow.cpp 32ef797eec0a6d54b868615fddfb9be5ec4574ce 
>   sublime/urldocument.h 4a02d898e9ebb3d11a0efd43142d22e2bdea1a9d 
> 
> Diff: https://git.reviewboard.kde.org/r/123279/diff/
> 
> 
> Testing
> -------
> 
> I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.
> 
> 
> Thanks,
> 
> Sebastien Speierer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150407/59028f28/attachment-0001.html>