Review Request 122896: port to kf5

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122896/#review78729
-----------------------------------------------------------

Ship it!


+1 from me, but I'd wait for another look from Milian


src/kgraphviewer.cpp (line 204)
<https://git.reviewboard.kde.org/r/122896/#comment53872>

    Casing => "Select Dot File", or even "Select DOT File"



src/part/CMakeLists.txt (line 50)
<https://git.reviewboard.kde.org/r/122896/#comment53873>

    Use the new-style names for Qt libs?



src/part/CMakeLists.txt (line 65)
<https://git.reviewboard.kde.org/r/122896/#comment53874>

    Use the new-style names for Qt libs?


- Kevin Funk


On March 11, 2015, 1:35 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122896/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 1:35 a.m.)
> 
> 
> Review request for KDevelop, Gaël de Chalendar and Milian Wolff.
> 
> 
> Repository: kgraphviewer
> 
> 
> Description
> -------
> 
> quick and dirty port to kf5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 815aea9 
>   doc/en_US/CMakeLists.txt 29b34a4 
>   src/CMakeLists.txt 92929a2 
>   src/KGraphEditorElementTreeWidget.cpp 62f8fec 
>   src/KGraphEditorNodesTreeWidget.cpp 6e7a596 
>   src/hi16-app-kgraphviewer.png 32d35d90f68aa4a3f7edc1fb34464ad45a4c2501 
>   src/hi16-apps-kgraphviewer.png PRE-CREATION 
>   src/hi32-app-kgraphviewer.png 61d52197378d9d8de52e047216fbc594f4c536a8 
>   src/hi32-apps-kgraphviewer.png PRE-CREATION 
>   src/kgrapheditor.h 483f8de 
>   src/kgrapheditor.cpp 8572fde 
>   src/kgrapheditorConfigDialog.h b172e71 
>   src/kgrapheditorConfigDialog.cpp e4e7d12 
>   src/kgrapheditormain.cpp a4a4f11 
>   src/kgraphviewer.h 2da64df 
>   src/kgraphviewer.cpp 065262b 
>   src/kgraphviewerConfigDialog.h 8691a5d 
>   src/kgraphviewerConfigDialog.cpp 2f8bd1c 
>   src/main.cpp dd650b3 
>   src/part/CMakeLists.txt 9ae38c3 
>   src/part/DotGraphParsingHelper.cpp 7d46837 
>   src/part/KgvGlobal.h 9033910 
>   src/part/KgvGlobal.cpp aa272d8 
>   src/part/KgvPageLayout.cpp 3c7f658 
>   src/part/KgvPageLayoutDia.h 66ef199 
>   src/part/KgvPageLayoutDia.cpp 3c84f5e 
>   src/part/KgvPageLayoutSize.h 693cab3 
>   src/part/KgvPageLayoutSize.cpp c2c51b1 
>   src/part/KgvUnit.cpp 251373a 
>   src/part/KgvUnitWidgets.h 5dc7d67 
>   src/part/KgvUnitWidgets.cpp 4057ed5 
>   src/part/canvasedge.h ce0f1b3 
>   src/part/canvasedge.cpp f51d566 
>   src/part/canvaselement.cpp 92470b5 
>   src/part/canvasnode.cpp ff045f8 
>   src/part/dot2qtconsts.cpp 8acabdb 
>   src/part/dotgrammar.cpp 82945da 
>   src/part/dotgraph.cpp 57c59b5 
>   src/part/dotgraphview.h f2bf416 
>   src/part/dotgraphview.cpp 97c1454 
>   src/part/graphedge.cpp 58a9c12 
>   src/part/graphelement.cpp 25471f5 
>   src/part/graphexporter.cpp 042cfe0 
>   src/part/graphnode.cpp 250dc81 
>   src/part/graphsubgraph.cpp eb11084 
>   src/part/kgraphviewer_export.h b171ec4 
>   src/part/kgraphviewer_part.h 062a560 
>   src/part/kgraphviewer_part.cpp 67a1001 
>   src/part/layoutagraphthread.h 3713e3d 
>   src/part/layoutagraphthread.cpp 51407a1 
>   src/part/loadagraphthread.cpp 27a10ee 
>   src/part/pannerview.cpp 0cb55ea 
>   src/part/simpleprintingcommand.cpp acd0c41 
>   src/part/simpleprintingengine.cpp 4a35616 
>   src/part/simpleprintingpagesetup.cpp 265e10f 
>   src/part/simpleprintingpagesetupbase.ui e8717f9 
>   src/part/simpleprintingsettings.cpp c92177b 
>   src/part/simpleprintpreviewwindow.h 63cc8a0 
>   src/part/simpleprintpreviewwindow.cpp dcf4f02 
>   src/part/simpleprintpreviewwindow_p.cpp 82211f5 
> 
> Diff: https://git.reviewboard.kde.org/r/122896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150409/ddc7a845/attachment-0001.html>