<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122896/">https://git.reviewboard.kde.org/r/122896/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 from me, but I'd wait for another look from Milian</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122896/diff/3/?file=354235#file354235line205" style="color: black; font-weight: bold; text-decoration: underline;">src/kgraphviewer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGraphViewerWindow::openUrl(const KUrl& url)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KGraphViewerWindow::openUrl(const QUrl& url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">i18n</span><span class="p">(</span><span class="s">"Select dot file"</span><span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Casing => "Select Dot File", or even "Select DOT File"</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122896/diff/3/?file=354239#file354239line50" style="color: black; font-weight: bold; text-decoration: underline;">src/part/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kgraphviewerlib</span> <span class="o">${</span><span class="nv">QT_QTSVG_LIBRARY</span><span class="o">}</span> <span class="o">${</span><span class="nv"><span class="hl">KDE4_KIO</span>_LIB<span class="hl">S</span></span><span class="o"><span class="hl">}</span></span> <span class="o">${</span><span class="nv">graphviz_LIBRARIES</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kgraphviewerlib</span> <span class="o">${</span><span class="nv">QT_QTSVG_LIBRARY</span><span class="o">}</span> <span class="o">${</span><span class="nv"><span class="hl">QT_QTCORE</span>_LIB<span class="hl">RARY</span></span><span class="o"><span class="hl">}</span></span><span class="hl"> </span><span class="s"><span class="hl">Qt5::PrintSupport</span></span><span class="hl"> </span><span class="s"><span class="hl">Qt5::Svg</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::KIOWidgets</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::KHtml</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::WidgetsAddons</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::IconThemes</span></span> <span class="o">${</span><span class="nv">graphviz_LIBRARIES</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use the new-style names for Qt libs?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122896/diff/3/?file=354239#file354239line65" style="color: black; font-weight: bold; text-decoration: underline;">src/part/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kgraphviewerpart</span> <span class="o">${</span><span class="nv"><span class="hl">KDE4_KPARTS</span>_LIB<span class="hl">S</span></span><span class="o"><span class="hl">}</span></span> <span class="s">gvc</span> <span class="s">cgraph</span> <span class="s">pathplan</span> <span class="s">cdt</span> <span class="s">kgraphviewerlib</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kgraphviewerpart</span> <span class="o">${</span><span class="nv"><span class="hl">QT_QTCORE</span>_LIB<span class="hl">RARY</span></span><span class="o"><span class="hl">}</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::Parts</span></span> <span class="s">gvc</span> <span class="s">cgraph</span> <span class="s">pathplan</span> <span class="s">cdt</span> <span class="s">kgraphviewerlib</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use the new-style names for Qt libs?</p></pre>
</div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On March 11th, 2015, 1:35 a.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Gaël de Chalendar and Milian Wolff.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated March 11, 2015, 1:35 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgraphviewer
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">quick and dirty port to kf5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(815aea9)</span></li>
<li>doc/en_US/CMakeLists.txt <span style="color: grey">(29b34a4)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(92929a2)</span></li>
<li>src/KGraphEditorElementTreeWidget.cpp <span style="color: grey">(62f8fec)</span></li>
<li>src/KGraphEditorNodesTreeWidget.cpp <span style="color: grey">(6e7a596)</span></li>
<li>src/hi16-app-kgraphviewer.png <span style="color: grey">(32d35d90f68aa4a3f7edc1fb34464ad45a4c2501)</span></li>
<li>src/hi16-apps-kgraphviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/hi32-app-kgraphviewer.png <span style="color: grey">(61d52197378d9d8de52e047216fbc594f4c536a8)</span></li>
<li>src/hi32-apps-kgraphviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kgrapheditor.h <span style="color: grey">(483f8de)</span></li>
<li>src/kgrapheditor.cpp <span style="color: grey">(8572fde)</span></li>
<li>src/kgrapheditorConfigDialog.h <span style="color: grey">(b172e71)</span></li>
<li>src/kgrapheditorConfigDialog.cpp <span style="color: grey">(e4e7d12)</span></li>
<li>src/kgrapheditormain.cpp <span style="color: grey">(a4a4f11)</span></li>
<li>src/kgraphviewer.h <span style="color: grey">(2da64df)</span></li>
<li>src/kgraphviewer.cpp <span style="color: grey">(065262b)</span></li>
<li>src/kgraphviewerConfigDialog.h <span style="color: grey">(8691a5d)</span></li>
<li>src/kgraphviewerConfigDialog.cpp <span style="color: grey">(2f8bd1c)</span></li>
<li>src/main.cpp <span style="color: grey">(dd650b3)</span></li>
<li>src/part/CMakeLists.txt <span style="color: grey">(9ae38c3)</span></li>
<li>src/part/DotGraphParsingHelper.cpp <span style="color: grey">(7d46837)</span></li>
<li>src/part/KgvGlobal.h <span style="color: grey">(9033910)</span></li>
<li>src/part/KgvGlobal.cpp <span style="color: grey">(aa272d8)</span></li>
<li>src/part/KgvPageLayout.cpp <span style="color: grey">(3c7f658)</span></li>
<li>src/part/KgvPageLayoutDia.h <span style="color: grey">(66ef199)</span></li>
<li>src/part/KgvPageLayoutDia.cpp <span style="color: grey">(3c84f5e)</span></li>
<li>src/part/KgvPageLayoutSize.h <span style="color: grey">(693cab3)</span></li>
<li>src/part/KgvPageLayoutSize.cpp <span style="color: grey">(c2c51b1)</span></li>
<li>src/part/KgvUnit.cpp <span style="color: grey">(251373a)</span></li>
<li>src/part/KgvUnitWidgets.h <span style="color: grey">(5dc7d67)</span></li>
<li>src/part/KgvUnitWidgets.cpp <span style="color: grey">(4057ed5)</span></li>
<li>src/part/canvasedge.h <span style="color: grey">(ce0f1b3)</span></li>
<li>src/part/canvasedge.cpp <span style="color: grey">(f51d566)</span></li>
<li>src/part/canvaselement.cpp <span style="color: grey">(92470b5)</span></li>
<li>src/part/canvasnode.cpp <span style="color: grey">(ff045f8)</span></li>
<li>src/part/dot2qtconsts.cpp <span style="color: grey">(8acabdb)</span></li>
<li>src/part/dotgrammar.cpp <span style="color: grey">(82945da)</span></li>
<li>src/part/dotgraph.cpp <span style="color: grey">(57c59b5)</span></li>
<li>src/part/dotgraphview.h <span style="color: grey">(f2bf416)</span></li>
<li>src/part/dotgraphview.cpp <span style="color: grey">(97c1454)</span></li>
<li>src/part/graphedge.cpp <span style="color: grey">(58a9c12)</span></li>
<li>src/part/graphelement.cpp <span style="color: grey">(25471f5)</span></li>
<li>src/part/graphexporter.cpp <span style="color: grey">(042cfe0)</span></li>
<li>src/part/graphnode.cpp <span style="color: grey">(250dc81)</span></li>
<li>src/part/graphsubgraph.cpp <span style="color: grey">(eb11084)</span></li>
<li>src/part/kgraphviewer_export.h <span style="color: grey">(b171ec4)</span></li>
<li>src/part/kgraphviewer_part.h <span style="color: grey">(062a560)</span></li>
<li>src/part/kgraphviewer_part.cpp <span style="color: grey">(67a1001)</span></li>
<li>src/part/layoutagraphthread.h <span style="color: grey">(3713e3d)</span></li>
<li>src/part/layoutagraphthread.cpp <span style="color: grey">(51407a1)</span></li>
<li>src/part/loadagraphthread.cpp <span style="color: grey">(27a10ee)</span></li>
<li>src/part/pannerview.cpp <span style="color: grey">(0cb55ea)</span></li>
<li>src/part/simpleprintingcommand.cpp <span style="color: grey">(acd0c41)</span></li>
<li>src/part/simpleprintingengine.cpp <span style="color: grey">(4a35616)</span></li>
<li>src/part/simpleprintingpagesetup.cpp <span style="color: grey">(265e10f)</span></li>
<li>src/part/simpleprintingpagesetupbase.ui <span style="color: grey">(e8717f9)</span></li>
<li>src/part/simpleprintingsettings.cpp <span style="color: grey">(c92177b)</span></li>
<li>src/part/simpleprintpreviewwindow.h <span style="color: grey">(63cc8a0)</span></li>
<li>src/part/simpleprintpreviewwindow.cpp <span style="color: grey">(dcf4f02)</span></li>
<li>src/part/simpleprintpreviewwindow_p.cpp <span style="color: grey">(82211f5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122896/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>