Review Request 123231: Added number of calls to the callgrind view
Kevin Funk
kfunk at kde.org
Tue Apr 7 07:49:53 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123231/#review78594
-----------------------------------------------------------
Ship it!
models/callgrinditem.h (line 79)
<https://git.reviewboard.kde.org/r/123231/#comment53769>
Nitpick: Space before `{`, remove one space after
- Kevin Funk
On April 2, 2015, 6:30 p.m., Laszlo Kis-Adam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123231/
> -----------------------------------------------------------
>
> (Updated April 2, 2015, 6:30 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-valgrind
>
>
> Description
> -------
>
> Added number of calls to the callgrind view..
>
>
> Diffs
> -----
>
> models/callgrinditem.h 654948c
> models/callgrinditem.cpp 42606a9
> models/callgrindmodel.cpp 3c73623
> models/icachegrinditem.h 0dd3ab1
> parsers/callgrindparser.h aae3ef1
> parsers/callgrindparser.cpp f6da3cf
>
> Diff: https://git.reviewboard.kde.org/r/123231/diff/
>
>
> Testing
> -------
>
> * built
> * installed
> * works as intended
>
> Screenshot:
> http://www.picbutler.de/bild/321452/20150402000002338kmmak.jpg
>
>
> Thanks,
>
> Laszlo Kis-Adam
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150407/c86eb86c/attachment.html>
More information about the KDevelop-devel
mailing list