Review Request 123231: Added number of calls to the callgrind view

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123231/#review78459
-----------------------------------------------------------

Ship it!



parsers/callgrindparser.cpp (line 33)
<https://git.reviewboard.kde.org/r/123231/#comment53676>

    Initialize before the constructor?
    , m_numCalls(0)


LGTM

- Aleix Pol Gonzalez


On April 2, 2015, 8:30 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123231/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 8:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Added number of calls to the callgrind view..
> 
> 
> Diffs
> -----
> 
>   models/callgrinditem.h 654948c 
>   models/callgrinditem.cpp 42606a9 
>   models/callgrindmodel.cpp 3c73623 
>   models/icachegrinditem.h 0dd3ab1 
>   parsers/callgrindparser.h aae3ef1 
>   parsers/callgrindparser.cpp f6da3cf 
> 
> Diff: https://git.reviewboard.kde.org/r/123231/diff/
> 
> 
> Testing
> -------
> 
> * built
> * installed
> * works as intended
> 
> Screenshot:
> http://www.picbutler.de/bild/321452/20150402000002338kmmak.jpg
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150403/49e0c235/attachment.html>