Review Request 123191: Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )

[Laszlo Kis-Adam]

> On April 1, 2015, 8:50 a.m., Kevin Funk wrote:
> > models/memcheckitemsimpl.cpp, line 116
> > <https://git.reviewboard.kde.org/r/123191/diff/2/?file=359667#file359667line116>
> >
> >     Style: No newline before `{` (exceptions: function defs, class decls, etc.)
> >     
> >     In general: Try to stick to the style used in the file already.
> >     
> >     Dito for other places.

While generally I don't mind nitpicking: IMHO We should have an astyle rule for these, and then everyone would have to just run astyle before commit...
That way everyone could focus on the actual problems :)


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123191/#review78315
-----------------------------------------------------------


On April 1, 2015, 5:06 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123191/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 5:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )
> 
> 
> Diffs
> -----
> 
>   marks.cpp 9adca2b 
>   models/memcheckitemsimpl.h b6d7a96 
>   models/memcheckitemsimpl.cpp 1b50b96 
>   models/memcheckmodel.cpp ad42605 
> 
> Diff: https://git.reviewboard.kde.org/r/123191/diff/
> 
> 
> Testing
> -------
> 
> * built
> * installed
> * it works as intended.
> 
> Take a look at the difference:
> Before:
> http://www.picbutler.de/bild/321320/20150331000002312k3ncw.jpg
> 
> After:
> http://www.picbutler.de/bild/321321/201503310000023132yrhe.jpg
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150401/a3b43f44/attachment-0001.html>