Review Request 123191: Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )

Kevin Funk kfunk at kde.org
Wed Apr 1 06:50:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123191/#review78315
-----------------------------------------------------------

Ship it!


Yeah, looking way better now!


models/memcheckitemsimpl.cpp (line 116)
<https://git.reviewboard.kde.org/r/123191/#comment53623>

    Style: No newline before `{` (exceptions: function defs, class decls, etc.)
    
    In general: Try to stick to the style used in the file already.
    
    Dito for other places.


- Kevin Funk


On April 1, 2015, 12:59 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123191/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 12:59 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )
> 
> 
> Diffs
> -----
> 
>   marks.cpp 9adca2b 
>   models/memcheckitemsimpl.h b6d7a96 
>   models/memcheckitemsimpl.cpp 1b50b96 
>   models/memcheckmodel.cpp ad42605 
> 
> Diff: https://git.reviewboard.kde.org/r/123191/diff/
> 
> 
> Testing
> -------
> 
> * built
> * installed
> * it works as intended.
> 
> Take a look at the difference:
> Before:
> http://www.picbutler.de/bild/321320/20150331000002312k3ncw.jpg
> 
> After:
> http://www.picbutler.de/bild/321321/201503310000023132yrhe.jpg
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150401/f00c5b7c/attachment.html>


More information about the KDevelop-devel mailing list