Review Request 123203: Fix Directory Assertion

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123203/#review78325
-----------------------------------------------------------



language/codegen/templateclassgenerator.cpp (line 109)
<https://git.reviewboard.kde.org/r/123203/#comment53624>

    Well wait, move the QFileInfo construction into the assert, this way it won't happen when running in release mode!


- Aleix Pol Gonzalez


On April 1, 2015, 8:51 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123203/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 8:51 a.m.)
> 
> 
> Review request for KDevelop and Simon Wächter.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Apparently path() is not guaranteed to return a trailing slash in case of directories.
> 
> 
> Diffs
> -----
> 
>   language/codegen/templateclassgenerator.cpp 6d7c7d8 
> 
> Diff: https://git.reviewboard.kde.org/r/123203/diff/
> 
> 
> Testing
> -------
> 
> In KDevelop:
> 
> 1. Right click on a folder
> 2. Click Create from Template
> 3. Choose C++|Basic|Basic
> 4. Click Next
> 
> Before this patch KDevelop would crash, after this patch it behaves properly.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150401/43b77e6a/attachment.html>