Review Request 123203: Fix Directory Assertion
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Apr 1 12:00:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123203/#review78324
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 1, 2015, 8:51 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123203/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 8:51 a.m.)
>
>
> Review request for KDevelop and Simon Wächter.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Apparently path() is not guaranteed to return a trailing slash in case of directories.
>
>
> Diffs
> -----
>
> language/codegen/templateclassgenerator.cpp 6d7c7d8
>
> Diff: https://git.reviewboard.kde.org/r/123203/diff/
>
>
> Testing
> -------
>
> In KDevelop:
>
> 1. Right click on a folder
> 2. Click Create from Template
> 3. Choose C++|Basic|Basic
> 4. Click Next
>
> Before this patch KDevelop would crash, after this patch it behaves properly.
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150401/50923678/attachment.html>
More information about the KDevelop-devel
mailing list