Review Request 120312: Port .cpp files from KDELibs4Support

[Jakub Caban]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/
-----------------------------------------------------------

(Updated Sept. 30, 2014, 8:45 p.m.)


Review request for KDevelop.


Changes
-------

Fix TODOS: one seems to be obsolete and other one was caused by QProgressDialog::close() emitting cancel for some reason.


Repository: kdev-upload


Description
-------

Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.


Diffs (updated)
-----

  uploadprofilemodel.cpp 16847b2 
  uploadprojectmodel.h 8379810 
  uploadprojectmodel.cpp 30db851 
  uploadprofiledlg.cpp ff234bd 
  uploadprofileitem.h b17187a 
  uploadprofileitem.cpp ee4610e 
  uploadpreferences.ui ac4c679 
  uploadprofiledlg.h d363190 
  uploadjob.cpp c58db45 
  uploadpreferences.cpp 0949c92 
  profilesfiletree.cpp 2c19df0 
  tests/CMakeLists.txt f4bc1a8 
  tests/permissions.cpp 8735c8d 
  CMakeLists.txt 3428c80 
  kdevuploadplugin.cpp 5261978 
  profilesfiletree.h c595f32 

Diff: https://git.reviewboard.kde.org/r/120312/diff/


Testing
-------

Code compiles and works with 2 regressions:
- Directory chooser for profile settings always opens user home folder instead of remote view
- upload job always reports 'Upload cancelled' even after succesfull upload


Thanks,

Jakub Caban

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140930/e8ccb711/attachment.html>