<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120312/">https://git.reviewboard.kde.org/r/120312/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2014, 8:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix TODOS: one seems to be obsolete and other one was caused by QProgressDialog::close() emitting cancel for some reason.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code compiles and works with 2 regressions:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Directory chooser for profile settings always opens user home folder instead of remote view<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- upload job always reports 'Upload cancelled' even after succesfull upload</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>uploadprofilemodel.cpp <span style="color: grey">(16847b2)</span></li>
<li>uploadprojectmodel.h <span style="color: grey">(8379810)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(30db851)</span></li>
<li>uploadprofiledlg.cpp <span style="color: grey">(ff234bd)</span></li>
<li>uploadprofileitem.h <span style="color: grey">(b17187a)</span></li>
<li>uploadprofileitem.cpp <span style="color: grey">(ee4610e)</span></li>
<li>uploadpreferences.ui <span style="color: grey">(ac4c679)</span></li>
<li>uploadprofiledlg.h <span style="color: grey">(d363190)</span></li>
<li>uploadjob.cpp <span style="color: grey">(c58db45)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(0949c92)</span></li>
<li>profilesfiletree.cpp <span style="color: grey">(2c19df0)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(f4bc1a8)</span></li>
<li>tests/permissions.cpp <span style="color: grey">(8735c8d)</span></li>
<li>CMakeLists.txt <span style="color: grey">(3428c80)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(5261978)</span></li>
<li>profilesfiletree.h <span style="color: grey">(c595f32)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120312/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>