Review Request 120273: Initial work on porting to Frameworks
Jakub Caban
kuba at whyblack.pl
Sun Sep 21 16:05:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120273/
-----------------------------------------------------------
(Updated Sept. 21, 2014, 4:05 p.m.)
Review request for KDevelop and Alexander Richardson.
Changes
-------
use better variable name.
Repository: kdev-upload
Description
-------
I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.
Diffs (updated)
-----
uploadprofiledlg.cpp 930f1c1
uploadprofilemodel.cpp 84e8a79
uploadpreferences.cpp 4b4380e
uploadjob.h 025bb7b
uploadjob.cpp b48e58c
uploaddialog.cpp 0600a7d
tests/CMakeLists.txt bb4f2f6
profilesfiletree.cpp fffe74e
kdevuploadplugin.cpp c805255
profilesfiletree.h 4718b1e
kdevuploadplugin.h 335b2b3
CMakeLists.txt 8e6baa4
kdevupload.desktop.cmake d3277a0
uploadprojectmodel.cpp 900b8d0
Diff: https://git.reviewboard.kde.org/r/120273/diff/
Testing
-------
It compiles and works as intended.
Missing bits:
- reading/saving uploaded file times
- shortcuts to upload actions are not saved
Those are KDevelop problems maybe?
Thanks,
Jakub Caban
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140921/f2769910/attachment.html>
More information about the KDevelop-devel
mailing list