Review Request 120273: Initial work on porting to Frameworks

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120273/#review67142
-----------------------------------------------------------

Ship it!


Looks sensible, thanks a lot! Can you submit this yourself?


uploadjob.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46853>

    a strange variable name ;)
    maybe projectFolder?


- Sven Brauch


On Sept. 21, 2014, 3:41 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120273/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 3:41 p.m.)
> 
> 
> Review request for KDevelop and Alexander Richardson.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8e6baa4 
>   kdevupload.desktop.cmake d3277a0 
>   kdevuploadplugin.h 335b2b3 
>   kdevuploadplugin.cpp c805255 
>   profilesfiletree.h 4718b1e 
>   profilesfiletree.cpp fffe74e 
>   tests/CMakeLists.txt bb4f2f6 
>   uploaddialog.cpp 0600a7d 
>   uploadjob.h 025bb7b 
>   uploadjob.cpp b48e58c 
>   uploadpreferences.cpp 4b4380e 
>   uploadprofiledlg.cpp 930f1c1 
>   uploadprofilemodel.cpp 84e8a79 
>   uploadprojectmodel.cpp 900b8d0 
> 
> Diff: https://git.reviewboard.kde.org/r/120273/diff/
> 
> 
> Testing
> -------
> 
> It compiles and works as intended.
> 
> Missing bits:
> - reading/saving uploaded file times
> - shortcuts to upload actions are not saved
> 
> Those are KDevelop problems maybe?
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140921/f4eb108d/attachment-0001.html>