Review Request 120249: port CMakeLists to new cmake library syntax
Kevin Funk
kfunk at kde.org
Thu Sep 18 18:18:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120249/#review66855
-----------------------------------------------------------
LGTM. And thanks for providing a script for this!
- Kevin Funk
On Sept. 17, 2014, 7:41 p.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120249/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 7:41 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> eg: KDev::Shell instead of ${KDEVPLATFORM_SHELL_LIBRARIES}
>
>
> Diffs
> -----
>
> languages/plugins/custom-definesandincludes/compilerprovider/CMakeLists.txt b1826e9
> languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt 98fc548
> kdeintegration/kdeprovider/CMakeLists.txt 9678880
> kdeintegration/kdeprovider/tests/CMakeLists.txt 385003c
> languages/cpp/CMakeLists.txt 37772ce
> languages/cpp/cppduchain/CMakeLists.txt 1cbdedf
> languages/cpp/cppduchain/tests/CMakeLists.txt d1b83f3
> languages/cpp/parser/CMakeLists.txt 8ecbf69
> languages/cpp/parser/headergen/CMakeLists.txt 49c7678
> languages/cpp/parser/rpp/CMakeLists.txt 24d2826
> languages/cpp/parser/rpp/tests/CMakeLists.txt d58681c
> languages/cpp/parser/tests/CMakeLists.txt 4779afc
> languages/cpp/tests/CMakeLists.txt c5ed97c
> languages/plugins/custom-definesandincludes/CMakeLists.txt 8bd32c4
> CMakeLists.txt eefb271
> app/CMakeLists.txt 59c7ef9
> debuggers/gdb/CMakeLists.txt 324c8a3
> debuggers/gdb/printers/tests/CMakeLists.txt 9c1a3d9
> documentation/manpage/CMakeLists.txt dffb611
> documentation/manpage/tests/CMakeLists.txt a15188a
> documentation/qthelp/CMakeLists.txt 21a225e
> documentation/qthelp/tests/CMakeLists.txt f13c8b9
> formatters/astyle/CMakeLists.txt 05d7587
> formatters/astyle/tests/CMakeLists.txt 9aa6c3a
> formatters/customscript/CMakeLists.txt 926f301
> projectmanagers/custommake/CMakeLists.txt 0b4368c
> projectmanagers/custommake/makefileresolver/CMakeLists.txt a05bab7
> providers/ghprovider/CMakeLists.txt e039499
> utils/okteta/CMakeLists.txt bf379f6
> languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt ea718ce
> languages/plugins/custom-definesandincludes/noprojectincludesanddefines/CMakeLists.txt 63c4f89
> languages/plugins/custom-definesandincludes/tests/CMakeLists.txt 7f79f7f
> projectbuilders/cmakebuilder/CMakeLists.txt 8d79075
> projectbuilders/makebuilder/CMakeLists.txt 3cbbeb5
> projectbuilders/ninjabuilder/CMakeLists.txt 048aef9
> projectmanagers/cmake/CMakeLists.txt eb64970
> projectmanagers/cmake/tests/CMakeLists.txt 5272a17
> projectmanagers/custom-buildsystem/CMakeLists.txt 6d1f165
> projectmanagers/custom-buildsystem/tests/CMakeLists.txt 2eb5ccb
>
> Diff: https://git.reviewboard.kde.org/r/120249/diff/
>
>
> Testing
> -------
>
> just build
>
>
> Thanks,
>
> Laurent Navet
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140918/fccc8bbe/attachment.html>
More information about the KDevelop-devel
mailing list