<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120249/">https://git.reviewboard.kde.org/r/120249/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM. And thanks for providing a script for this!</p></pre>
<br />
<p>- Kevin Funk</p>
<br />
<p>On September 17th, 2014, 7:41 p.m. UTC, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2014, 7:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">eg: KDev::Shell instead of ${KDEVPLATFORM_SHELL_LIBRARIES}</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just build</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/plugins/custom-definesandincludes/compilerprovider/CMakeLists.txt <span style="color: grey">(b1826e9)</span></li>
<li>languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt <span style="color: grey">(98fc548)</span></li>
<li>kdeintegration/kdeprovider/CMakeLists.txt <span style="color: grey">(9678880)</span></li>
<li>kdeintegration/kdeprovider/tests/CMakeLists.txt <span style="color: grey">(385003c)</span></li>
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(37772ce)</span></li>
<li>languages/cpp/cppduchain/CMakeLists.txt <span style="color: grey">(1cbdedf)</span></li>
<li>languages/cpp/cppduchain/tests/CMakeLists.txt <span style="color: grey">(d1b83f3)</span></li>
<li>languages/cpp/parser/CMakeLists.txt <span style="color: grey">(8ecbf69)</span></li>
<li>languages/cpp/parser/headergen/CMakeLists.txt <span style="color: grey">(49c7678)</span></li>
<li>languages/cpp/parser/rpp/CMakeLists.txt <span style="color: grey">(24d2826)</span></li>
<li>languages/cpp/parser/rpp/tests/CMakeLists.txt <span style="color: grey">(d58681c)</span></li>
<li>languages/cpp/parser/tests/CMakeLists.txt <span style="color: grey">(4779afc)</span></li>
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(c5ed97c)</span></li>
<li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(8bd32c4)</span></li>
<li>CMakeLists.txt <span style="color: grey">(eefb271)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(59c7ef9)</span></li>
<li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(324c8a3)</span></li>
<li>debuggers/gdb/printers/tests/CMakeLists.txt <span style="color: grey">(9c1a3d9)</span></li>
<li>documentation/manpage/CMakeLists.txt <span style="color: grey">(dffb611)</span></li>
<li>documentation/manpage/tests/CMakeLists.txt <span style="color: grey">(a15188a)</span></li>
<li>documentation/qthelp/CMakeLists.txt <span style="color: grey">(21a225e)</span></li>
<li>documentation/qthelp/tests/CMakeLists.txt <span style="color: grey">(f13c8b9)</span></li>
<li>formatters/astyle/CMakeLists.txt <span style="color: grey">(05d7587)</span></li>
<li>formatters/astyle/tests/CMakeLists.txt <span style="color: grey">(9aa6c3a)</span></li>
<li>formatters/customscript/CMakeLists.txt <span style="color: grey">(926f301)</span></li>
<li>projectmanagers/custommake/CMakeLists.txt <span style="color: grey">(0b4368c)</span></li>
<li>projectmanagers/custommake/makefileresolver/CMakeLists.txt <span style="color: grey">(a05bab7)</span></li>
<li>providers/ghprovider/CMakeLists.txt <span style="color: grey">(e039499)</span></li>
<li>utils/okteta/CMakeLists.txt <span style="color: grey">(bf379f6)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt <span style="color: grey">(ea718ce)</span></li>
<li>languages/plugins/custom-definesandincludes/noprojectincludesanddefines/CMakeLists.txt <span style="color: grey">(63c4f89)</span></li>
<li>languages/plugins/custom-definesandincludes/tests/CMakeLists.txt <span style="color: grey">(7f79f7f)</span></li>
<li>projectbuilders/cmakebuilder/CMakeLists.txt <span style="color: grey">(8d79075)</span></li>
<li>projectbuilders/makebuilder/CMakeLists.txt <span style="color: grey">(3cbbeb5)</span></li>
<li>projectbuilders/ninjabuilder/CMakeLists.txt <span style="color: grey">(048aef9)</span></li>
<li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(eb64970)</span></li>
<li>projectmanagers/cmake/tests/CMakeLists.txt <span style="color: grey">(5272a17)</span></li>
<li>projectmanagers/custom-buildsystem/CMakeLists.txt <span style="color: grey">(6d1f165)</span></li>
<li>projectmanagers/custom-buildsystem/tests/CMakeLists.txt <span style="color: grey">(2eb5ccb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120249/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>