Review Request 120237: port to ecm_add_test

[Laurent Navet]

> On sep. 16, 2014, 11:20 après-midi, Kevin Funk wrote:
> > languages/cpp/tests/CMakeLists.txt, line 134
> > <https://git.reviewboard.kde.org/r/120237/diff/1/?file=312620#file312620line134>
> >
> >     This is not a test but just a plain executable for manual testing, just use add_executable here, don't mark as test.

right, i'have been confused by ecm_mark_as_test()


> On sep. 16, 2014, 11:20 après-midi, Kevin Funk wrote:
> > documentation/qthelp/tests/CMakeLists.txt, line 4
> > <https://git.reviewboard.kde.org/r/120237/diff/1/?file=312619#file312619line4>
> >
> >     Rename the file as well.
> >     
> >     Btw, you don't even need TEST_NAME I think. The name is deduced from the first source file passed to ecm_add_test.

TEST_NAME is needed because testqthelpplugin.cpp is not the only one source file.

extract from ECMAddTests.cmake :
"TEST_NAME may be ommited if there is exactly one source file. In that case the name of the source file will be used as test name"


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120237/#review66714
-----------------------------------------------------------


On sep. 16, 2014, 8:46 après-midi, Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120237/
> -----------------------------------------------------------
> 
> (Updated sep. 16, 2014, 8:46 après-midi)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> simplify CMakeLists by using ecm_add_test macro
> 
> 
> Diffs
> -----
> 
>   languages/cpp/tests/CMakeLists.txt c5ed97c 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt 98fc548 
>   documentation/manpage/tests/CMakeLists.txt a15188a 
>   documentation/qthelp/tests/CMakeLists.txt f13c8b9 
> 
> Diff: https://git.reviewboard.kde.org/r/120237/diff/
> 
> 
> Testing
> -------
> 
> no regression seen
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140917/e35d1ed5/attachment.html>