Review Request 120237: port to ecm_add_test

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120237/#review66714
-----------------------------------------------------------



documentation/qthelp/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120237/#comment46498>

    Rename the file as well.
    
    Btw, you don't even need TEST_NAME I think. The name is deduced from the first source file passed to ecm_add_test.



documentation/qthelp/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120237/#comment46496>

    Fix the name please, name it 'test_qthelpplugin'



languages/cpp/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120237/#comment46497>

    This is not a test but just a plain executable for manual testing, just use add_executable here, don't mark as test.


- Kevin Funk


On Sept. 16, 2014, 6:46 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120237/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 6:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> simplify CMakeLists by using ecm_add_test macro
> 
> 
> Diffs
> -----
> 
>   languages/cpp/tests/CMakeLists.txt c5ed97c 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt 98fc548 
>   documentation/manpage/tests/CMakeLists.txt a15188a 
>   documentation/qthelp/tests/CMakeLists.txt f13c8b9 
> 
> Diff: https://git.reviewboard.kde.org/r/120237/diff/
> 
> 
> Testing
> -------
> 
> no regression seen
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140916/7e69c3a1/attachment.html>