Review Request 120176: Suggest file buddies based on DUChain
Max Schwarz
max.schwarz at online.de
Sat Sep 13 11:18:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120176/
-----------------------------------------------------------
(Updated Sept. 13, 2014, 11:18 vorm.)
Review request for KDevelop.
Changes
-------
Fixed style issues, added unit tests and added a missing DUChainReadLocker
Repository: kdev-clang
Description
-------
Many projects have source trees with split include / source folders.
In that situation the path-based buddy finder does not work. So
examine DUChain declarations/definitions and rank possible buddy files
to find the most probably one. If we found such a buddy file, add it
to the suggestions.
Of course, this improvement does not depend on kdev-clang. If you point
me towards a suitable place in kdevplatform, I can also add it there.
Diffs (updated)
-----
documentfinderhelpers.cpp 6535ab9
tests/test_buddies.h 1c6f8f3
tests/test_buddies.cpp da1fcea
Diff: https://git.reviewboard.kde.org/r/120176/diff/
Testing
-------
Tested on a medium codebase (>100 source files) with the SwitchToBuddy shortcut (Ctrl+Alt+c). Works fine with no visible performance drop.
Thanks,
Max Schwarz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140913/2dd7d4fa/attachment.html>
More information about the KDevelop-devel
mailing list