Review Request 120176: Suggest file buddies based on DUChain

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120176/#review66382
-----------------------------------------------------------


Nice idea!

Code looks decent, but please add tests. That fits nicely into the 'TestBuddies' unit test.

General coding-style related remarks:
- s/KDevelop::// in implementation files (use 'using namespace KDevelop;')
- Always put braces around if/else blocks, put space after keywords (if, else, ...)

You're right about that this would be nice to have language agnostic, but we can move that also later on, when it has evolved a bit. So, let's just put this into kdev-clang for now.

Thanks

- Kevin Funk


On Sept. 12, 2014, 10:56 p.m., Max Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120176/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 10:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Many projects have source trees with split include / source folders.
> In that situation the path-based buddy finder does not work. So
> examine DUChain declarations/definitions and rank possible buddy files
> to find the most probably one. If we found such a buddy file, add it
> to the suggestions.
> 
> Of course, this improvement does not depend on kdev-clang. If you point
> me towards a suitable place in kdevplatform, I can also add it there.
> 
> 
> Diffs
> -----
> 
>   documentfinderhelpers.cpp 6535ab9 
> 
> Diff: https://git.reviewboard.kde.org/r/120176/diff/
> 
> 
> Testing
> -------
> 
> Tested on a medium codebase (>100 source files) with the SwitchToBuddy shortcut (Ctrl+Alt+c). Works fine with no visible performance drop.
> 
> 
> Thanks,
> 
> Max Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/d5b7ec88/attachment-0001.html>