Review Request 120107: Port platform/debugger from KUrl to QUrl

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120107/#review66111
-----------------------------------------------------------



debugger/util/pathmappings.cpp
<https://git.reviewboard.kde.org/r/120107/#comment46138>

    Doesn't that change behavior? It would probably be safer if we passed a url around in this case. I can see how this could be a problem for remote debuggers.
    
    If you want, add a comment of something and fix it in a further review.


Other than that it looks ok.

- Aleix Pol Gonzalez


On Sept. 9, 2014, 5:01 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120107/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 5:01 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port platform/debugger from KUrl to QUrl
> 
> 
> Diffs
> -----
> 
>   debugger/breakpoint/breakpoint.h 7be3a8d 
>   debugger/breakpoint/breakpoint.cpp ff5962b 
>   debugger/breakpoint/breakpointmodel.h 8b5739a 
>   debugger/breakpoint/breakpointmodel.cpp 16bd156 
>   debugger/breakpoint/breakpointwidget.cpp 9ec0402 
>   debugger/framestack/framestackmodel.h dbd3478 
>   debugger/framestack/framestackwidget.cpp f9a89f6 
>   debugger/interfaces/idebugsession.h d1db611 
>   debugger/interfaces/idebugsession.cpp 9f55f42 
>   debugger/interfaces/iframestackmodel.h 33deecd 
>   debugger/util/pathmappings.h 20cf9f0 
>   debugger/util/pathmappings.cpp dd87424 
>   shell/debugcontroller.h 0c525b5 
>   shell/debugcontroller.cpp 6946819 
> 
> Diff: https://git.reviewboard.kde.org/r/120107/diff/
> 
> 
> Testing
> -------
> 
> I didn't notice our tests were broken, otherwise I would've started with that instead of this. Oh well, next.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140909/de8a5f34/attachment.html>