<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120107/">https://git.reviewboard.kde.org/r/120107/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120107/diff/1/?file=310467#file310467line178" style="color: black; font-weight: bold; text-decoration: underline;">debugger/util/pathmappings.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_paths</span><span class="p">[</span><span class="n">index</span><span class="p">.</span><span class="n">row</span><span class="p">()].</span><span class="n">remote</span> <span class="o">=</span> <span class="n"><span class="hl">K</span>Url</span><span class="p">(</span><span class="n">value</span><span class="p">.</span><span class="n">toString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_paths</span><span class="p">[</span><span class="n">index</span><span class="p">.</span><span class="n">row</span><span class="p">()].</span><span class="n">remote</span> <span class="o">=</span> <span class="n"><span class="hl">Q</span>Url</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromUserInput</span></span><span class="p">(</span><span class="n">value</span><span class="p">.</span><span class="n">toString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Doesn't that change behavior? It would probably be safer if we passed a url around in this case. I can see how this could be a problem for remote debuggers.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you want, add a comment of something and fix it in a further review.</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other than that it looks ok.</p></pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On September 9th, 2014, 5:01 a.m. UTC, Olivier Jean de Gaalon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Olivier Jean de Gaalon.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2014, 5:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port platform/debugger from KUrl to QUrl</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't notice our tests were broken, otherwise I would've started with that instead of this. Oh well, next.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/breakpoint/breakpoint.h <span style="color: grey">(7be3a8d)</span></li>
<li>debugger/breakpoint/breakpoint.cpp <span style="color: grey">(ff5962b)</span></li>
<li>debugger/breakpoint/breakpointmodel.h <span style="color: grey">(8b5739a)</span></li>
<li>debugger/breakpoint/breakpointmodel.cpp <span style="color: grey">(16bd156)</span></li>
<li>debugger/breakpoint/breakpointwidget.cpp <span style="color: grey">(9ec0402)</span></li>
<li>debugger/framestack/framestackmodel.h <span style="color: grey">(dbd3478)</span></li>
<li>debugger/framestack/framestackwidget.cpp <span style="color: grey">(f9a89f6)</span></li>
<li>debugger/interfaces/idebugsession.h <span style="color: grey">(d1db611)</span></li>
<li>debugger/interfaces/idebugsession.cpp <span style="color: grey">(9f55f42)</span></li>
<li>debugger/interfaces/iframestackmodel.h <span style="color: grey">(33deecd)</span></li>
<li>debugger/util/pathmappings.h <span style="color: grey">(20cf9f0)</span></li>
<li>debugger/util/pathmappings.cpp <span style="color: grey">(dd87424)</span></li>
<li>shell/debugcontroller.h <span style="color: grey">(0c525b5)</span></li>
<li>shell/debugcontroller.cpp <span style="color: grey">(6946819)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120107/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>