Review Request 119938: Switch to QApplication in reviewboard test

Dāvis Mosāns davispuh at gmail.com
Tue Sep 9 00:10:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 3:10 a.m.)


Review request for KDevelop.


Repository: kdevplatform


Description
-------

Switch to QApplication in reviewboard test

* KAboutData instead of K4AboutData
* QCommandLineParser instead of KCmdLineArgs


Diffs (updated)
-----

  plugins/reviewboard/reviewboardjobs.cpp 72e4c1340edddaeb9b56e7eb623f93dc1f8372f5 
  plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
  plugins/reviewboard/reviewboardjobs.h 5282e167a436977407928555600383cea0c9c2ea 

Diff: https://git.reviewboard.kde.org/r/119938/diff/


Testing
-------

Compiles and seems to be working.


Thanks,

Dāvis Mosāns

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140909/3494b525/attachment.html>


More information about the KDevelop-devel mailing list