Review Request 119938: Switch to QApplication in reviewboard test

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review65682
-----------------------------------------------------------



plugins/reviewboard/reviewboardjobs.h
<https://git.reviewboard.kde.org/r/119938/#comment45904>

    'parent' is always supposed to be the last param in the arg list, that's convention.



plugins/reviewboard/reviewboardjobs.h
<https://git.reviewboard.kde.org/r/119938/#comment45905>

    Not needed, is it?



plugins/reviewboard/reviewboardjobs.h
<https://git.reviewboard.kde.org/r/119938/#comment45907>

    Not needed either, right?
    
    The 'ReviewRequest" class doesn't call this method, hence it's kind of useless to make this a protected virtual method.



plugins/reviewboard/reviewboardjobs.h
<https://git.reviewboard.kde.org/r/119938/#comment45908>

    Both member vars should be 'private' then (only initialized once via ctor, can be accessed via getters.


- Kevin Funk


On Aug. 26, 2014, 6:39 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 6:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Switch to QApplication in reviewboard test
> 
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
>   plugins/reviewboard/reviewboardjobs.h 5282e167a436977407928555600383cea0c9c2ea 
>   plugins/reviewboard/reviewboardjobs.cpp 72e4c1340edddaeb9b56e7eb623f93dc1f8372f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140902/14f6dffd/attachment.html>