Review Request 120068: kdev-php: porting to KF5.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120068/#review65916
-----------------------------------------------------------

Ship it!


awesome!!!!!!! thank you so much for this. some small nitpicks - ignore at will and I'll have to clean it up after you. much appreciated!


CMakeLists.txt
<https://git.reviewboard.kde.org/r/120068/#comment46038>

    I think this is obsoleted by KDECMakeSettings above.



completion/context.h
<https://git.reviewboard.kde.org/r/120068/#comment46044>

    can we get that typedef into KDevplatform? also, please use it below



completion/context.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46042>

    does `{parentContext.data()}` work?
    
    also add a typedef for that to kdevplatform and use it below



completion/implementationitem.h
<https://git.reviewboard.kde.org/r/120068/#comment46043>

    here and elsewhere: please add `override` at the end to make sure this keeps working



duchain/builders/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46045>

    can't you just say `&& m_currentFunctionType`?



phplanguagesupport.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46039>

    QStringLiteral



phplanguagesupport.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46041>

    somewhere at the top, add "using namespace KTextEditor" and remove the `KTextEditor::` here and below.



phplanguagesupport.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46040>

    return {};



testprovider/phpunitprovider.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46047>

    `#include <KPluginLoader>` ?



testprovider/phpunitprovider.cpp
<https://git.reviewboard.kde.org/r/120068/#comment46048>

    `QStringLiteral`


- Milian Wolff


On Sept. 5, 2014, 1:35 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120068/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 1:35 p.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and Niko Sams.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> I use the kdev-php plugin at work, so I decided to port it myself. Moreover, this patch depends on the review request #120067. This port is not over though:
> 
> 1. Some tests are failing.
> 2. The unittestprovider plugin is not linking properly.
> 
> I'll work on this in the following days, but I thought of submitting this patch to reviewboard so you guys can give me some tips and point me to some errors :)
> 
> And yes, this patch is a bit large, sorry about that ;)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7387738 
>   completion/CMakeLists.txt 96746d3 
>   completion/codemodelitem.h 5a30852 
>   completion/codemodelitem.cpp fce05ba 
>   completion/context.h dc3bf74 
>   duchain/completioncodemodel.cpp 96b10e1 
>   duchain/declarations/classdeclaration.h 59c5926 
>   duchain/declarations/classmethoddeclaration.h 976a500 
>   duchain/declarations/functiondeclaration.h 404624d 
>   duchain/declarations/functiondeclaration.cpp 17386d9 
>   duchain/declarations/namespacealiasdeclaration.h 321a2b7 
>   duchain/declarations/namespacedeclaration.h c6691cc 
>   duchain/expressionevaluationresult.cpp d89f86f 
>   duchain/helper.h 9b55955 
>   duchain/navigation/magicconstantnavigationcontext.h 1065bf5 
>   duchain/navigation/magicconstantnavigationcontext.cpp 878d1f6 
>   duchain/navigation/navigationwidget.h eba8be9 
>   duchain/navigation/navigationwidget.cpp cf2c4f3 
>   duchain/tests/CMakeLists.txt bf365ad 
>   duchain/tests/duchain.cpp 5d983d4 
>   duchain/tests/duchain_multiplefiles.cpp ffd48c5 
>   duchain/tests/duchaintestbase.cpp 21dec92 
>   duchain/tests/expressionparser.cpp 17d0bbe 
>   duchain/types/integraltypeextended.h 9043fd5 
>   duchain/types/structuretype.h 2d80be5 
>   parser/CMakeLists.txt 49dbb54 
>   parser/main.cpp 42f2128 
>   parser/parsesession.h b365a4d 
>   parser/parsesession.cpp 2b11828 
>   parser/php.g dd0394c 
>   phplanguagesupport.h 6112646 
>   phplanguagesupport.cpp aab1ba8 
>   testprovider/CMakeLists.txt 95df50d 
>   testprovider/phpunitprovider.cpp 0f87886 
>   testprovider/testdoxdelegate.h cc2a48d 
>   duchain/CMakeLists.txt 3b40524 
>   duchain/builders/declarationbuilder.cpp 9ba4b84 
>   duchain/builders/typebuilder.cpp a8e7354 
>   duchain/completioncodemodel.h 5ed4799 
>   completion/includefileitem.h 95282cc 
>   completion/includefileitem.cpp 428547f 
>   completion/item.h e643ef0 
>   completion/item.cpp accb1e2 
>   completion/keyworditem.h 03a8357 
>   completion/keyworditem.cpp 58314ed 
>   completion/model.cpp ba7d7ca 
>   completion/tests/CMakeLists.txt 2db6e35 
>   completion/tests/test_completion.cpp 3bafd8b 
>   completion/worker.h c45ae8c 
>   completion/context.cpp 71cd035 
>   completion/implementationitem.h 6f173fc 
>   completion/implementationitem.cpp d67ea54 
> 
> Diff: https://git.reviewboard.kde.org/r/120068/diff/
> 
> 
> Testing
> -------
> 
> On the works. Some tests are failing.
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140906/2173c548/attachment-0001.html>