<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120068/">https://git.reviewboard.kde.org/r/120068/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">awesome!!!!!!! thank you so much for this. some small nitpicks - ignore at will and I'll have to clean it up after you. much appreciated!</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309882#file309882line30" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">enable_testing</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think this is obsoleted by KDECMakeSettings above.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309886#file309886line45" style="color: black; font-weight: bold; text-decoration: underline;">completion/context.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class Cursor;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">typedef</span> <span class="n"><span class="hl">K</span>Shared<span class="hl">Pt</span>r</span><span class="o"><</span><span class="n">CompletionTreeItem</span><span class="o">></span> <span class="n">CompletionTreeItemPointer</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">typedef</span> <span class="n"><span class="hl">QExplicitly</span>Shared<span class="hl">DataPointe</span>r</span><span class="o"><</span><span class="n">CompletionTreeItem</span><span class="o">></span> <span class="n">CompletionTreeItemPointer</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can we get that typedef into KDevplatform? also, please use it below</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309887#file309887line1573" style="color: black; font-weight: bold; text-decoration: underline;">completion/context.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<CompletionTreeItemPointer> CodeCompletionContext::completionItems(bool& abort, bool fullCompletion)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1573</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KDevelop</span><span class="o">::</span><span class="n">CodeCompletionContext</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Ptr</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">staticCast</span></span><span class="p">(</span><span class="n">parentContext</span><span class="p"><span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1573</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QExplicitlySharedDataPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n">KDevelop</span><span class="o">::</span><span class="n">CodeCompletionContext</span><span class="o"><span class="hl">></span></span><span class="p">(</span><span class="n">parentContext</span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">data</span></span><span class="p"><span class="hl">())</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">does <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">{parentContext.data()}</code> work?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also add a typedef for that to kdevplatform and use it below</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309888#file309888line44" style="color: black; font-weight: bold; text-decoration: underline;">completion/implementationitem.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="nf">execute</span><span class="p">(</span><span class="n">KTextEditor</span><span class="o">::</span><span class="n"><span class="hl">Document</span></span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n"><span class="hl">document</span></span><span class="p">,</span> <span class="k">const</span> <span class="n">KTextEditor</span><span class="o">::</span><span class="n">Range</span><span class="o">&</span> <span class="n">word</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="nf">execute</span><span class="p">(</span><span class="n">KTextEditor</span><span class="o">::</span><span class="n"><span class="hl">View</span></span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n"><span class="hl">view</span></span><span class="p">,</span> <span class="k">const</span> <span class="n">KTextEditor</span><span class="o">::</span><span class="n">Range</span><span class="o">&</span> <span class="n">word</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">here and elsewhere: please add <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">override</code> at the end to make sure this keeps working</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309901#file309901line1165" style="color: black; font-weight: bold; text-decoration: underline;">duchain/builders/declarationbuilder.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DeclarationBuilder::visitFunctionCallParameterList(FunctionCallParameterListAst* node)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1165</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_findVariable</span><span class="p">.</span><span class="n">node</span> <span class="o">&&</span> <span class="o"><span class="hl">!</span></span><span class="n">m_currentFunctionType</span><span class="p">.</span><span class="n"><span class="hl">isNull</span></span><span class="p">()</span> <span class="o">&&</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1165</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_findVariable</span><span class="p">.</span><span class="n">node</span> <span class="o">&&</span> <span class="n">m_currentFunctionType</span><span class="p">.</span><span class="n"><span class="hl">data</span></span><span class="p">()</span> <span class="o">&&</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can't you just say <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">&& m_currentFunctionType</code>?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309930#file309930line75" style="color: black; font-weight: bold; text-decoration: underline;">phplanguagesupport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">K_EXPORT_PLUGIN(KDevPhpSupportFactory(</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">:</span> <span class="n">KDevelop</span><span class="o">::</span><span class="n">IPlugin</span><span class="p">(</span><span class="n"><span class="hl">KDevPhpS</span>upport<span class="hl">Factory</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">componentData</span></span><span class="p"><span class="hl">(</span>),</span> <span class="n">parent</span><span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">:</span> <span class="n">KDevelop</span><span class="o">::</span><span class="n">IPlugin</span><span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"kdevphps</span>upport<span class="hl">"</span></span><span class="p">),</span> <span class="n">parent</span><span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QStringLiteral</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309930#file309930line163" style="color: black; font-weight: bold; text-decoration: underline;">phplanguagesupport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KDevelop::ContextMenuExtension LanguageSupport::contextMenuExtension(Context* context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QPair</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span> <span class="n"><span class="hl">Simple</span>Range</span><span class="o">></span> <span class="n">LanguageSupport</span><span class="o">::</span><span class="n">wordUnderCursor</span><span class="p">(</span><span class="k">const</span> <span class="n">KUrl</span><span class="o">&</span> <span class="n">url</span><span class="p">,</span> <span class="k">const</span> <span class="n"><span class="hl">Simple</span>Cursor</span><span class="o">&</span> <span class="n">position</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QPair</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span> <span class="n"><span class="hl">KTextEditor</span></span><span class="o"><span class="hl">::</span></span><span class="n">Range</span><span class="o">></span> <span class="n">LanguageSupport</span><span class="o">::</span><span class="n">wordUnderCursor</span><span class="p">(</span><span class="k">const</span> <span class="n">KUrl</span><span class="o">&</span> <span class="n">url</span><span class="p">,</span> <span class="k">const</span> <span class="n"><span class="hl">KTextEditor</span></span><span class="o"><span class="hl">::</span></span><span class="n">Cursor</span><span class="o">&</span> <span class="n">position</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">somewhere at the top, add "using namespace KTextEditor" and remove the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KTextEditor::</code> here and below.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309930#file309930line167" style="color: black; font-weight: bold; text-decoration: underline;">phplanguagesupport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KDevelop::ContextMenuExtension LanguageSupport::contextMenuExtension(Context* context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">167</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">qMakePair</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span class="n"><span class="hl">Simple</span>Range</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">invalid</span></span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">167</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">qMakePair</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span class="n"><span class="hl">KTextEditor</span></span><span class="o"><span class="hl">::</span></span><span class="n">Range</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">return {};</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309932#file309932line40" style="color: black; font-weight: bold; text-decoration: underline;">testprovider/phpunitprovider.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <kpluginloader.h></span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KAboutData></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KAboutData></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#include <KPluginLoader></code> ?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120068/diff/2/?file=309932#file309932line53" style="color: black; font-weight: bold; text-decoration: underline;">testprovider/phpunitprovider.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">using namespace KDevelop;</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">using</span> <span class="k">namespace</span> <span class="n">KDevelop</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">PhpUnitProvider</span><span class="o">::</span><span class="n">PhpUnitProvider</span><span class="p">(</span><span class="n">QObject</span><span class="o">*</span> <span class="n">parent</span><span class="p">,</span> <span class="k">const</span> <span class="n">QList</span><span class="o"><</span> <span class="n">QVariant</span> <span class="o">>&</span> <span class="n">args</span><span class="p">)</span><span class="o">:</span> <span class="n">IPlugin</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"kdevphpunitprovider"</span><span class="p">),</span> <span class="n">parent</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStringLiteral</code></p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On September 5th, 2014, 1:35 p.m. UTC, Miquel Sabaté Solà wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Milian Wolff and Niko Sams.</div>
<div>By Miquel Sabaté Solà.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2014, 1:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-php
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I use the kdev-php plugin at work, so I decided to port it myself. Moreover, this patch depends on the review request #120067. This port is not over though:</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Some tests are failing.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The unittestprovider plugin is not linking properly.</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll work on this in the following days, but I thought of submitting this patch to reviewboard so you guys can give me some tips and point me to some errors :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And yes, this patch is a bit large, sorry about that ;)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On the works. Some tests are failing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7387738)</span></li>
<li>completion/CMakeLists.txt <span style="color: grey">(96746d3)</span></li>
<li>completion/codemodelitem.h <span style="color: grey">(5a30852)</span></li>
<li>completion/codemodelitem.cpp <span style="color: grey">(fce05ba)</span></li>
<li>completion/context.h <span style="color: grey">(dc3bf74)</span></li>
<li>duchain/completioncodemodel.cpp <span style="color: grey">(96b10e1)</span></li>
<li>duchain/declarations/classdeclaration.h <span style="color: grey">(59c5926)</span></li>
<li>duchain/declarations/classmethoddeclaration.h <span style="color: grey">(976a500)</span></li>
<li>duchain/declarations/functiondeclaration.h <span style="color: grey">(404624d)</span></li>
<li>duchain/declarations/functiondeclaration.cpp <span style="color: grey">(17386d9)</span></li>
<li>duchain/declarations/namespacealiasdeclaration.h <span style="color: grey">(321a2b7)</span></li>
<li>duchain/declarations/namespacedeclaration.h <span style="color: grey">(c6691cc)</span></li>
<li>duchain/expressionevaluationresult.cpp <span style="color: grey">(d89f86f)</span></li>
<li>duchain/helper.h <span style="color: grey">(9b55955)</span></li>
<li>duchain/navigation/magicconstantnavigationcontext.h <span style="color: grey">(1065bf5)</span></li>
<li>duchain/navigation/magicconstantnavigationcontext.cpp <span style="color: grey">(878d1f6)</span></li>
<li>duchain/navigation/navigationwidget.h <span style="color: grey">(eba8be9)</span></li>
<li>duchain/navigation/navigationwidget.cpp <span style="color: grey">(cf2c4f3)</span></li>
<li>duchain/tests/CMakeLists.txt <span style="color: grey">(bf365ad)</span></li>
<li>duchain/tests/duchain.cpp <span style="color: grey">(5d983d4)</span></li>
<li>duchain/tests/duchain_multiplefiles.cpp <span style="color: grey">(ffd48c5)</span></li>
<li>duchain/tests/duchaintestbase.cpp <span style="color: grey">(21dec92)</span></li>
<li>duchain/tests/expressionparser.cpp <span style="color: grey">(17d0bbe)</span></li>
<li>duchain/types/integraltypeextended.h <span style="color: grey">(9043fd5)</span></li>
<li>duchain/types/structuretype.h <span style="color: grey">(2d80be5)</span></li>
<li>parser/CMakeLists.txt <span style="color: grey">(49dbb54)</span></li>
<li>parser/main.cpp <span style="color: grey">(42f2128)</span></li>
<li>parser/parsesession.h <span style="color: grey">(b365a4d)</span></li>
<li>parser/parsesession.cpp <span style="color: grey">(2b11828)</span></li>
<li>parser/php.g <span style="color: grey">(dd0394c)</span></li>
<li>phplanguagesupport.h <span style="color: grey">(6112646)</span></li>
<li>phplanguagesupport.cpp <span style="color: grey">(aab1ba8)</span></li>
<li>testprovider/CMakeLists.txt <span style="color: grey">(95df50d)</span></li>
<li>testprovider/phpunitprovider.cpp <span style="color: grey">(0f87886)</span></li>
<li>testprovider/testdoxdelegate.h <span style="color: grey">(cc2a48d)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(3b40524)</span></li>
<li>duchain/builders/declarationbuilder.cpp <span style="color: grey">(9ba4b84)</span></li>
<li>duchain/builders/typebuilder.cpp <span style="color: grey">(a8e7354)</span></li>
<li>duchain/completioncodemodel.h <span style="color: grey">(5ed4799)</span></li>
<li>completion/includefileitem.h <span style="color: grey">(95282cc)</span></li>
<li>completion/includefileitem.cpp <span style="color: grey">(428547f)</span></li>
<li>completion/item.h <span style="color: grey">(e643ef0)</span></li>
<li>completion/item.cpp <span style="color: grey">(accb1e2)</span></li>
<li>completion/keyworditem.h <span style="color: grey">(03a8357)</span></li>
<li>completion/keyworditem.cpp <span style="color: grey">(58314ed)</span></li>
<li>completion/model.cpp <span style="color: grey">(ba7d7ca)</span></li>
<li>completion/tests/CMakeLists.txt <span style="color: grey">(2db6e35)</span></li>
<li>completion/tests/test_completion.cpp <span style="color: grey">(3bafd8b)</span></li>
<li>completion/worker.h <span style="color: grey">(c45ae8c)</span></li>
<li>completion/context.cpp <span style="color: grey">(71cd035)</span></li>
<li>completion/implementationitem.h <span style="color: grey">(6f173fc)</span></li>
<li>completion/implementationitem.cpp <span style="color: grey">(d67ea54)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120068/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>