Review Request 121269: Fix local imports

[Radek Novacek]

> On Nov. 27, 2014, 11:55 a.m., Aleix Pol Gonzalez wrote:
> > duchain/contextbuilder.cpp, line 334
> > <https://git.reviewboard.kde.org/r/121269/diff/1/?file=330799#file330799line334>
> >
> >     You want ::toLocalFile(). ::path() is not portable.

I've copy&paste it from KUrl documentation:

http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKUrl.html#a5e3eb64abffcbb15709d47bf23cb1901

`since 5.0, use url.adjusted(QUrl::RemoveFilename).path(), which behaves like ObeyTrailingSlash though.`


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121269/#review71009
-----------------------------------------------------------


On Nov. 27, 2014, 11:52 a.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121269/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 11:52 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Looks like it got ported from KUrl incorrectly.
> 
> This change fixes PyDUChainTest::testRelativeImport test.
> 
> 
> Diffs
> -----
> 
>   duchain/contextbuilder.cpp 2cbba03f40813b8b66d3d4f04c87506894bdbb68 
> 
> Diff: https://git.reviewboard.kde.org/r/121269/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141127/ec4c350f/attachment.html>