Review Request 121269: Fix local imports
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Nov 27 11:55:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121269/#review71009
-----------------------------------------------------------
duchain/contextbuilder.cpp
<https://git.reviewboard.kde.org/r/121269/#comment49599>
You want ::toLocalFile(). ::path() is not portable.
- Aleix Pol Gonzalez
On Nov. 27, 2014, 11:52 a.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121269/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 11:52 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-python
>
>
> Description
> -------
>
> Looks like it got ported from KUrl incorrectly.
>
> This change fixes PyDUChainTest::testRelativeImport test.
>
>
> Diffs
> -----
>
> duchain/contextbuilder.cpp 2cbba03f40813b8b66d3d4f04c87506894bdbb68
>
> Diff: https://git.reviewboard.kde.org/r/121269/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141127/ae144732/attachment.html>
More information about the KDevelop-devel
mailing list