Review Request 121061: Fix environment-cd when launching a debugsession in a path containing spaces

[Nicolas Werner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121061/
-----------------------------------------------------------

(Updated Nov. 15, 2014, 7:27 nachm.)


Review request for KDevelop.


Changes
-------

Next try. I actually have no idea, where I should place the breakpoint, as I have no experience with the unit test framework.
Is this ok?

At least the space works as expected.


Bugs: 339231
    http://bugs.kde.org/show_bug.cgi?id=339231


Repository: kdevelop


Description
-------

Problem: GDBMI only accepts paths containing spaces if they are in double quotes otherwise cd will fail.
Solution: Add prepend and append double quotes to the dir string instead of using KShell::quoteArg


Diffs (updated)
-----

  debuggers/gdb/debugsession.cpp e37c5b7 
  debuggers/gdb/unittests/CMakeLists.txt 2dd8a03 
  debuggers/gdb/unittests/gdbtest.h 6117bd8 
  debuggers/gdb/unittests/gdbtest.cpp 172c48b 
  with PRE-CREATION 
  with PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121061/diff/


Testing
-------

I did a patch for 4.7, that fixed the problem, but I can't build master at the moment, so I don't know, if this compiles. It should fix the bug tough, as it is only a quoting issue.

Should I also attatch the patch for the 4.7 branch?


File Attachments
----------------

patch with unit test
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/13/57f573ca-fa7e-4478-9be4-8431bf5597e5__0001-Fix-launching-a-debugsession-in-a-path-containing-sp.patch


Thanks,

Nicolas Werner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141115/cd81b242/attachment.html>