Review Request 121061: Fix environment-cd when launching a debugsession in a path containing spaces

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121061/#review70366
-----------------------------------------------------------



debuggers/gdb/unittests/gdbtest.cpp
<https://git.reviewboard.kde.org/r/121061/#comment49199>

    shouldn't this be in line 25 and to verify the path is correct?



with
<https://git.reviewboard.kde.org/r/121061/#comment49200>

    could you instead check `QDir::currentPath()` against `QCoreApplication::applicationDirPath`? See http://qt-project.org/doc/qt-5/qcoreapplication.html#applicationDirPath
    
    that way we don't need the other file and are much more explicit in what we want to test here


- Milian Wolff


On Nov. 14, 2014, 2:34 p.m., Nicolas Werner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121061/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 2:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 339231
>     http://bugs.kde.org/show_bug.cgi?id=339231
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Problem: GDBMI only accepts paths containing spaces if they are in double quotes otherwise cd will fail.
> Solution: Add prepend and append double quotes to the dir string instead of using KShell::quoteArg
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/unittests/gdbtest.cpp 172c48b 
>   with PRE-CREATION 
>   with PRE-CREATION 
>   with PRE-CREATION 
>   debuggers/gdb/debugsession.cpp e37c5b7 
>   debuggers/gdb/unittests/CMakeLists.txt 17ec6ae 
>   debuggers/gdb/unittests/gdbtest.h 6117bd8 
> 
> Diff: https://git.reviewboard.kde.org/r/121061/diff/
> 
> 
> Testing
> -------
> 
> I did a patch for 4.7, that fixed the problem, but I can't build master at the moment, so I don't know, if this compiles. It should fix the bug tough, as it is only a quoting issue.
> 
> Should I also attatch the patch for the 4.7 branch?
> 
> 
> File Attachments
> ----------------
> 
> patch with unit test
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/13/57f573ca-fa7e-4478-9be4-8431bf5597e5__0001-Fix-launching-a-debugsession-in-a-path-containing-sp.patch
> 
> 
> Thanks,
> 
> Nicolas Werner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141114/ce0b9e01/attachment.html>