Review Request 120190: port away from KStandardDirs

Sven Brauch svenbrauch at googlemail.com
Thu Nov 13 15:51:14 UTC 2014



> On Oct. 9, 2014, 12:39 p.m., Milian Wolff wrote:
> > ping? any progress on this? sven, do you maybe want to apply it locally and see whether it all works and then push this change?
> 
> Laurent Navet wrote:
>     not yet, I wait for Frameworks 5.3 to appear in my favorite package manager to be able to rebuild up to date kdevplatform/kdevelop
>     (that should be very soon now)!
> 
> Milian Wolff wrote:
>     ping again? Sven, could you otherwise adopt this and merge it?

I was a bit reluctant to merge this because of the breakage it is likely to introduce without testing each individual change. Unfortunately test coverage isn't too great for this path stuff either. Laurent, did you get around to do some tests already?


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120190/#review68148
-----------------------------------------------------------


On Sept. 13, 2014, 8:37 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120190/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 8:37 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> replace deprecated KStandardDirs by QStandardPaths
> 
> 
> Diffs
> -----
> 
>   pythonlanguagesupport.cpp 397bd41 
>   codecompletion/context.cpp cd88efd 
>   codecompletion/tests/pycompletiontest.cpp d55430f 
>   debugger/debugjob.cpp 504971f 
>   debugger/debugsession.cpp bbcafe9 
>   docfilekcm/docfilemanagerwidget.cpp 88ab17a 
>   docfilekcm/docfilewizard.cpp da104c5 
>   duchain/assistants/missingincludeassistant.cpp 0b53a74 
>   duchain/contextbuilder.cpp 99c4d9c 
>   duchain/correctionhelper.cpp 04eb329 
>   duchain/helpers.cpp 7676be6 
>   duchain/tests/duchainbench.cpp 4c717e9 
>   duchain/tests/pyduchaintest.cpp c587442 
> 
> Diff: https://git.reviewboard.kde.org/r/120190/diff/
> 
> 
> Testing
> -------
> 
> just build
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141113/8fc5550e/attachment-0001.html>


More information about the KDevelop-devel mailing list