<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120190/">https://git.reviewboard.kde.org/r/120190/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 9th, 2014, 12:39 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping? any progress on this? sven, do you maybe want to apply it locally and see whether it all works and then push this change?</p></pre>
</blockquote>
<p>On October 9th, 2014, 1:08 p.m. UTC, <b>Laurent Navet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">not yet, I wait for Frameworks 5.3 to appear in my favorite package manager to be able to rebuild up to date kdevplatform/kdevelop
(that should be very soon now)!</p></pre>
</blockquote>
<p>On November 13th, 2014, 3:47 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping again? Sven, could you otherwise adopt this and merge it?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was a bit reluctant to merge this because of the breakage it is likely to introduce without testing each individual change. Unfortunately test coverage isn't too great for this path stuff either. Laurent, did you get around to do some tests already?</p></pre>
<br />
<p>- Sven</p>
<br />
<p>On September 13th, 2014, 8:37 p.m. UTC, Laurent Navet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Laurent Navet.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2014, 8:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-python
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace deprecated KStandardDirs by QStandardPaths</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just build</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>pythonlanguagesupport.cpp <span style="color: grey">(397bd41)</span></li>
<li>codecompletion/context.cpp <span style="color: grey">(cd88efd)</span></li>
<li>codecompletion/tests/pycompletiontest.cpp <span style="color: grey">(d55430f)</span></li>
<li>debugger/debugjob.cpp <span style="color: grey">(504971f)</span></li>
<li>debugger/debugsession.cpp <span style="color: grey">(bbcafe9)</span></li>
<li>docfilekcm/docfilemanagerwidget.cpp <span style="color: grey">(88ab17a)</span></li>
<li>docfilekcm/docfilewizard.cpp <span style="color: grey">(da104c5)</span></li>
<li>duchain/assistants/missingincludeassistant.cpp <span style="color: grey">(0b53a74)</span></li>
<li>duchain/contextbuilder.cpp <span style="color: grey">(99c4d9c)</span></li>
<li>duchain/correctionhelper.cpp <span style="color: grey">(04eb329)</span></li>
<li>duchain/helpers.cpp <span style="color: grey">(7676be6)</span></li>
<li>duchain/tests/duchainbench.cpp <span style="color: grey">(4c717e9)</span></li>
<li>duchain/tests/pyduchaintest.cpp <span style="color: grey">(c587442)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120190/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>