Review Request 119830: Remove deprecated IProject methods

[Milian Wolff]

> On Oct. 15, 2014, 2:05 p.m., Milian Wolff wrote:
> > I'm OK with this landing, but imo we must first port the other modules, otherwise they will all fail to compile. Can you make sure that is the case? Otherwise commit this but do not remove the deprecated methods yet.
> 
> Dāvis Mosāns wrote:
>     KDevelop can't be compiled with this, it uses project->folder and maybe other methods. Need to update KDevelop first.

you should then tackle such issues from the other way around. I.e. first fix KDevelop and the other important plugins, then adopt KDevplatform. The way it is now, this just keeps this useful work in review limbo :-/


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119830/#review68454
-----------------------------------------------------------


On Oct. 15, 2014, 1:44 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119830/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 1:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.
> 
> 
> Diffs
> -----
> 
>   plugins/executescript/scriptappconfig.cpp 19b22e7361dd968477b32d2247deb30ce53cfdd4 
>   plugins/dashboard/kdevprojectdashboard.cpp e16a5a8fddb2cb6536ab19cb3b47197f9ba50fa4 
>   plugins/execute/nativeappconfig.cpp b0eca9c9712b6a4ff2759180c54a35cc0168fe0f 
>   interfaces/iproject.h 6936821eb4cfab294f605b54b044ad90b73bd66a 
>   plugins/dashboard/dashboarddataengine.cpp 332f1d27218f52d5fff5866d6d6345a4ee16b5f2 
>   plugins/dashboard/dashboarddocument.cpp 26293a66f967391747484bcdb81ac6ca929bd4f4 
>   plugins/externalscript/externalscriptjob.cpp 44753ef735940b4d6017778835d8955d2cb945d3 
>   plugins/filetemplates/templateclassassistant.cpp f9e27e4387abb0bf2f9a2f54ff2ec0b9fdc3ebc8 
>   plugins/grepview/grepdialog.cpp 69ed226feafeee7b22516d39efb372826c4f6790 
>   plugins/projectmanagerview/projectmanagerview.cpp 7a6379af765958b4c81d2fc94cf3789492ae9e47 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp 3f4f3ab1351097b071e951e1a58733b1289d06f6 
>   project/projectmodel.h b8310c7d9b8dc14f490fb2c1a1861d51071b77c2 
>   project/projectmodel.cpp 91aaac32ad33a510bc02edb41811b0fc5cd4ea79 
>   shell/project.h 4f893c595d75e249d2b2d7cdcacc0c322cecedf3 
>   shell/project.cpp 9369b8e20586f1db1d62a24b4b1af0e9d15f1a18 
>   shell/projectcontroller.cpp e549155a3b7fc3ac3e6c642c2c9e2c123af11b7c 
>   tests/testproject.h 3aa8e0ecb8fa527c425cb36af40bbdfd0ceb2fad 
>   tests/testproject.cpp 39a6d0be6505fcb7f5e130f27481fe02b89a7446 
>   vcs/models/brancheslistmodel.cpp 5f16c9deafd21aae41b110a0398282e67cd0de43 
> 
> Diff: https://git.reviewboard.kde.org/r/119830/diff/
> 
> 
> Testing
> -------
> 
> Tests does pass :)
> 
> but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141113/92503573/attachment.html>