Review Request 120620: Added the "finally" keyword.

Miquel Sabaté Solà mikisabate at gmail.com
Tue Nov 11 14:19:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120620/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 2:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop, Milian Wolff and Niko Sams.


Repository: kdev-php


Description
-------

Since [PHP 5.5](http://php.net/manual/en/migration55.new-features.php), try/catch block can end with a "finally" clause. I've added this keyword to the parser.


Diffs
-----

  duchain/tests/uses.h c51846a 
  duchain/tests/uses.cpp 9e7c408 
  parser/php.g c80fe76 
  parser/phplexer.cpp 20d1b2e 
  parser/test/lexertest.h 49fb380 
  parser/test/lexertest.cpp a53175c 

Diff: https://git.reviewboard.kde.org/r/120620/diff/


Testing
-------

Added a test in the lexer and another one to check that it marks uses of statements inside the finally block.


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141111/921100d3/attachment.html>


More information about the KDevelop-devel mailing list