Review Request 120620: Added the "finally" keyword.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120620/#review70231
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Oct. 17, 2014, 1:43 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120620/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 1:43 p.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and Niko Sams.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> Since [PHP 5.5](http://php.net/manual/en/migration55.new-features.php), try/catch block can end with a "finally" clause. I've added this keyword to the parser.
> 
> 
> Diffs
> -----
> 
>   duchain/tests/uses.h c51846a 
>   duchain/tests/uses.cpp 9e7c408 
>   parser/php.g c80fe76 
>   parser/phplexer.cpp 20d1b2e 
>   parser/test/lexertest.h 49fb380 
>   parser/test/lexertest.cpp a53175c 
> 
> Diff: https://git.reviewboard.kde.org/r/120620/diff/
> 
> 
> Testing
> -------
> 
> Added a test in the lexer and another one to check that it marks uses of statements inside the finally block.
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141111/42d593d8/attachment.html>