Review Request 121074: Config pages without KCMs (KDevelop part)

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121074/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevelop


Description
-------

Port QtHelp plugin to new config page architecture


Convert NinjaBuilder to new config page infrastructure


Fix wrong include guard naming


Convert MakeBuilder to new ConfigPage architecture


Convert custom buildsystem to new ConfigPage architecture


Convert custom defines and includes to new ConfigPage architecture


Convert cmake builder to new ConfigPage architecture


Convert cmake manager to new ConfigPage architecture


Don't use deprecated method


Adapt to EnvironmentConfigureButton move from kdevutil to kdevshell


Diffs
-----

  projectbuilders/cmakebuilder/kdevcmakebuilder.desktop.cmake 50dd08eb488bac090bf0a9dc1def254fe1b020c7 
  projectbuilders/makebuilder/CMakeLists.txt 18cc3e812d4f741e4a0dfdedab6e882fac3ceed1 
  projectbuilders/makebuilder/kcm_kdev_makebuilder.desktop.cmake ccb47c3bf51fd8857af557484d31012b59252fec 
  projectbuilders/makebuilder/makebuilder.h c0b6d1e23c19ac1a238f07d4344a93d1738126ff 
  projectbuilders/makebuilder/makebuilder.cpp d4397d8aa0cdfd2108aeef93464f466deec9b79f 
  projectbuilders/makebuilder/makebuilderconfig.kcfgc b0a8750a8c5298f1dd3193d69c35cfdab4b7c127 
  projectbuilders/makebuilder/makebuilderpreferences.h 72ff4b8ad599a9239432507c042fef9108d32eea 
  projectbuilders/makebuilder/makebuilderpreferences.cpp c5057d0ae598bd0af8c4afe480338e9f15dffddb 
  projectbuilders/ninjabuilder/ninjabuilderpreferences.h cffc695e21c53d1c6090e4f66b15118b1b3f2024 
  projectbuilders/ninjabuilder/ninjabuilderpreferences.cpp 4113cbfd34990537e69012b66cbd6a40a02c2c15 
  projectmanagers/cmake/CMakeLists.txt 3ad1b6b4d7f093af3adbb09442462397005d87c0 
  projectmanagers/cmake/cmakemanager.h 52eb6a76a20fab26bf18715aa5d7eff0d19103ff 
  projectmanagers/cmake/cmakemanager.cpp 752c9c32c58616c916b6cf0df940433400833d88 
  languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt 2c0265b1b3599da0a3f7f57dcec1b8c818bea11a 
  languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp 51649f7c5b01a187356fb496d9042b7d8297db30 
  languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp ff14d20a3d6d8cd2bbbf006cddb71d7c695eed4e 
  languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp a458db66e47420dee8156e84b7aff0cc71c24ab3 
  languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.h ee2e6a440f5252a4bf988744b941d6e086009a4c 
  languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 892b0abe380e9cac065e7f5075867743cb805ca5 
  languages/plugins/custom-definesandincludes/kcm_widget/kcm_kdevcustomdefinesandincludes.desktop.cmake 80599505087473bb5f48f8c99e1d547fba4d90da 
  languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 7461a157920cdf259c35985b000aa9f2987afb09 
  languages/plugins/custom-definesandincludes/tests/CMakeLists.txt 5b55e6ec62a23e6ca53b58c8cc1f1730a4a14fc4 
  projectbuilders/cmakebuilder/CMakeLists.txt c0b587ff4f25ac16e9184a68a24e56be5427ebfd 
  projectbuilders/cmakebuilder/cmakebuilder.h 0bd652b0434d0b47409d23e5c330d2e58d5e11c0 
  projectbuilders/cmakebuilder/cmakebuilder.cpp 3adc253ddbc257d6ef42fe03f43918aa17ec1259 
  projectbuilders/cmakebuilder/cmakebuilderpreferences.h 36a6b93de4f72eca11e42275d47b1cf2a7210752 
  projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp 191c62219ec2eb1f8dc7cde76427cebe5dbbbb4a 
  projectbuilders/cmakebuilder/kcm_kdev_cmakebuilder.desktop.cmake 70ea3414da88fa10d6770d318c36081b7acab777 
  documentation/qthelp/CMakeLists.txt 531128d6055934f1f67418432334aea42345a6a6 
  documentation/qthelp/kdevqthelp_config.desktop.cmake cdaefab66ccf2ee5aecfe54b4b4ade83861b918d 
  documentation/qthelp/qthelpconfig.h 0415a630097f4715bfb83640b2ace99bd3219879 
  documentation/qthelp/qthelpconfig.cpp 05d5b792909315aa031049754f9ea1a4e926dde5 
  documentation/qthelp/qthelpplugin.h 8ea5d67047ecec64bff9285cb4fd7f23af065b93 
  documentation/qthelp/qthelpplugin.cpp 892c059f4c434ec0e02379713c5d743707897100 
  documentation/qthelp/qthelpprovider.h 32ad98a2c2feff153681dc53aa85d0efac53dba4 
  documentation/qthelp/tests/CMakeLists.txt b0a1903e433714078fa9b5faa3e74ca940763aa5 
  languages/plugins/custom-definesandincludes/CMakeLists.txt 9ac2246590b21bbffd83187e12ef76f1afda79bf 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt 19bcdae463990dcd737f93d2f23a69a2c1bbeaac 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.h 83a4b9e3a83f47168141c1af62bd2f93c44a19ae 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp 0061826be745e229f2de9aa0743da3f9a8920ef2 
  projectbuilders/ninjabuilder/CMakeLists.txt 8e7aaee74be41c2b2538065279683959495bbfe0 
  projectbuilders/ninjabuilder/kcm_kdev_ninjabuilder.desktop.cmake cb12bd3440f1ca0225b878a371a5dd65624e4dbe 
  projectbuilders/ninjabuilder/kdevninjabuilderplugin.h 70e2e43277a4a4d3a99aa394a53cffd1fc7abc89 
  projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp fba4a778002b19b2cf7056e86f48482d8a86de0f 
  projectbuilders/ninjabuilder/ninjabuilderconfig.kcfg e9063d4b84b6eb7744dda87d9af534cc920afe29 
  projectbuilders/ninjabuilder/ninjabuilderconfig.kcfgc d33e6ad0981e3ece82fa8f422a3a09cd22a4be78 
  projectmanagers/cmake/kcm_kdevcmake_settings.desktop.cmake 9362b3cd9f437e5e8e6661c99a1153eccf79a6f3 
  projectmanagers/cmake/settings/cmakepreferences.h 2e8c1ca08e9a1b07f65b995a5f42573f1932b0b0 
  projectmanagers/cmake/settings/cmakepreferences.cpp 0411cecf0b7eb43577dedf3e5dc6c6bb9ebfacbe 
  projectmanagers/custom-buildsystem/CMakeLists.txt 27e706a5669104f5e7ef5a9b38c1217de3be8e6b 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.h f6ae9744c03325aa8355099c0163b4e858104451 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp c2a5602515245ea93aeeb84cb57932a6212b11de 
  projectmanagers/custom-buildsystem/kcm_custombuildsystem.h 36d9251e718509ce0e174052dd7f4798fb3ee5c6 
  projectmanagers/custom-buildsystem/kcm_custombuildsystem.cpp 7f03fd700795dfc402cde2fbd243494fc158164a 
  projectmanagers/custom-buildsystem/kcm_kdevcustombuildsystem.desktop.cmake 60c626ee7e0f4584ced8e4385e1a62b67d40d39b 

Diff: https://git.reviewboard.kde.org/r/121074/diff/


Testing
-------


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/e1bdc8da/attachment-0001.html>