<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121074/">https://git.reviewboard.kde.org/r/121074/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port QtHelp plugin to new config page architecture</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert NinjaBuilder to new config page infrastructure</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix wrong include guard naming</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert MakeBuilder to new ConfigPage architecture</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert custom buildsystem to new ConfigPage architecture</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert custom defines and includes to new ConfigPage architecture</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert cmake builder to new ConfigPage architecture</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert cmake manager to new ConfigPage architecture</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't use deprecated method</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adapt to EnvironmentConfigureButton move from kdevutil to kdevshell</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/cmakebuilder/kdevcmakebuilder.desktop.cmake <span style="color: grey">(50dd08eb488bac090bf0a9dc1def254fe1b020c7)</span></li>
<li>projectbuilders/makebuilder/CMakeLists.txt <span style="color: grey">(18cc3e812d4f741e4a0dfdedab6e882fac3ceed1)</span></li>
<li>projectbuilders/makebuilder/kcm_kdev_makebuilder.desktop.cmake <span style="color: grey">(ccb47c3bf51fd8857af557484d31012b59252fec)</span></li>
<li>projectbuilders/makebuilder/makebuilder.h <span style="color: grey">(c0b6d1e23c19ac1a238f07d4344a93d1738126ff)</span></li>
<li>projectbuilders/makebuilder/makebuilder.cpp <span style="color: grey">(d4397d8aa0cdfd2108aeef93464f466deec9b79f)</span></li>
<li>projectbuilders/makebuilder/makebuilderconfig.kcfgc <span style="color: grey">(b0a8750a8c5298f1dd3193d69c35cfdab4b7c127)</span></li>
<li>projectbuilders/makebuilder/makebuilderpreferences.h <span style="color: grey">(72ff4b8ad599a9239432507c042fef9108d32eea)</span></li>
<li>projectbuilders/makebuilder/makebuilderpreferences.cpp <span style="color: grey">(c5057d0ae598bd0af8c4afe480338e9f15dffddb)</span></li>
<li>projectbuilders/ninjabuilder/ninjabuilderpreferences.h <span style="color: grey">(cffc695e21c53d1c6090e4f66b15118b1b3f2024)</span></li>
<li>projectbuilders/ninjabuilder/ninjabuilderpreferences.cpp <span style="color: grey">(4113cbfd34990537e69012b66cbd6a40a02c2c15)</span></li>
<li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(3ad1b6b4d7f093af3adbb09442462397005d87c0)</span></li>
<li>projectmanagers/cmake/cmakemanager.h <span style="color: grey">(52eb6a76a20fab26bf18715aa5d7eff0d19103ff)</span></li>
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(752c9c32c58616c916b6cf0df940433400833d88)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt <span style="color: grey">(2c0265b1b3599da0a3f7f57dcec1b8c818bea11a)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp <span style="color: grey">(51649f7c5b01a187356fb496d9042b7d8297db30)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp <span style="color: grey">(ff14d20a3d6d8cd2bbbf006cddb71d7c695eed4e)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp <span style="color: grey">(a458db66e47420dee8156e84b7aff0cc71c24ab3)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.h <span style="color: grey">(ee2e6a440f5252a4bf988744b941d6e086009a4c)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp <span style="color: grey">(892b0abe380e9cac065e7f5075867743cb805ca5)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/kcm_kdevcustomdefinesandincludes.desktop.cmake <span style="color: grey">(80599505087473bb5f48f8c99e1d547fba4d90da)</span></li>
<li>languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui <span style="color: grey">(7461a157920cdf259c35985b000aa9f2987afb09)</span></li>
<li>languages/plugins/custom-definesandincludes/tests/CMakeLists.txt <span style="color: grey">(5b55e6ec62a23e6ca53b58c8cc1f1730a4a14fc4)</span></li>
<li>projectbuilders/cmakebuilder/CMakeLists.txt <span style="color: grey">(c0b587ff4f25ac16e9184a68a24e56be5427ebfd)</span></li>
<li>projectbuilders/cmakebuilder/cmakebuilder.h <span style="color: grey">(0bd652b0434d0b47409d23e5c330d2e58d5e11c0)</span></li>
<li>projectbuilders/cmakebuilder/cmakebuilder.cpp <span style="color: grey">(3adc253ddbc257d6ef42fe03f43918aa17ec1259)</span></li>
<li>projectbuilders/cmakebuilder/cmakebuilderpreferences.h <span style="color: grey">(36a6b93de4f72eca11e42275d47b1cf2a7210752)</span></li>
<li>projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp <span style="color: grey">(191c62219ec2eb1f8dc7cde76427cebe5dbbbb4a)</span></li>
<li>projectbuilders/cmakebuilder/kcm_kdev_cmakebuilder.desktop.cmake <span style="color: grey">(70ea3414da88fa10d6770d318c36081b7acab777)</span></li>
<li>documentation/qthelp/CMakeLists.txt <span style="color: grey">(531128d6055934f1f67418432334aea42345a6a6)</span></li>
<li>documentation/qthelp/kdevqthelp_config.desktop.cmake <span style="color: grey">(cdaefab66ccf2ee5aecfe54b4b4ade83861b918d)</span></li>
<li>documentation/qthelp/qthelpconfig.h <span style="color: grey">(0415a630097f4715bfb83640b2ace99bd3219879)</span></li>
<li>documentation/qthelp/qthelpconfig.cpp <span style="color: grey">(05d5b792909315aa031049754f9ea1a4e926dde5)</span></li>
<li>documentation/qthelp/qthelpplugin.h <span style="color: grey">(8ea5d67047ecec64bff9285cb4fd7f23af065b93)</span></li>
<li>documentation/qthelp/qthelpplugin.cpp <span style="color: grey">(892c059f4c434ec0e02379713c5d743707897100)</span></li>
<li>documentation/qthelp/qthelpprovider.h <span style="color: grey">(32ad98a2c2feff153681dc53aa85d0efac53dba4)</span></li>
<li>documentation/qthelp/tests/CMakeLists.txt <span style="color: grey">(b0a1903e433714078fa9b5faa3e74ca940763aa5)</span></li>
<li>languages/plugins/custom-definesandincludes/CMakeLists.txt <span style="color: grey">(9ac2246590b21bbffd83187e12ef76f1afda79bf)</span></li>
<li>languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt <span style="color: grey">(19bcdae463990dcd737f93d2f23a69a2c1bbeaac)</span></li>
<li>languages/plugins/custom-definesandincludes/definesandincludesmanager.h <span style="color: grey">(83a4b9e3a83f47168141c1af62bd2f93c44a19ae)</span></li>
<li>languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp <span style="color: grey">(0061826be745e229f2de9aa0743da3f9a8920ef2)</span></li>
<li>projectbuilders/ninjabuilder/CMakeLists.txt <span style="color: grey">(8e7aaee74be41c2b2538065279683959495bbfe0)</span></li>
<li>projectbuilders/ninjabuilder/kcm_kdev_ninjabuilder.desktop.cmake <span style="color: grey">(cb12bd3440f1ca0225b878a371a5dd65624e4dbe)</span></li>
<li>projectbuilders/ninjabuilder/kdevninjabuilderplugin.h <span style="color: grey">(70e2e43277a4a4d3a99aa394a53cffd1fc7abc89)</span></li>
<li>projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp <span style="color: grey">(fba4a778002b19b2cf7056e86f48482d8a86de0f)</span></li>
<li>projectbuilders/ninjabuilder/ninjabuilderconfig.kcfg <span style="color: grey">(e9063d4b84b6eb7744dda87d9af534cc920afe29)</span></li>
<li>projectbuilders/ninjabuilder/ninjabuilderconfig.kcfgc <span style="color: grey">(d33e6ad0981e3ece82fa8f422a3a09cd22a4be78)</span></li>
<li>projectmanagers/cmake/kcm_kdevcmake_settings.desktop.cmake <span style="color: grey">(9362b3cd9f437e5e8e6661c99a1153eccf79a6f3)</span></li>
<li>projectmanagers/cmake/settings/cmakepreferences.h <span style="color: grey">(2e8c1ca08e9a1b07f65b995a5f42573f1932b0b0)</span></li>
<li>projectmanagers/cmake/settings/cmakepreferences.cpp <span style="color: grey">(0411cecf0b7eb43577dedf3e5dc6c6bb9ebfacbe)</span></li>
<li>projectmanagers/custom-buildsystem/CMakeLists.txt <span style="color: grey">(27e706a5669104f5e7ef5a9b38c1217de3be8e6b)</span></li>
<li>projectmanagers/custom-buildsystem/custombuildsystemplugin.h <span style="color: grey">(f6ae9744c03325aa8355099c0163b4e858104451)</span></li>
<li>projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp <span style="color: grey">(c2a5602515245ea93aeeb84cb57932a6212b11de)</span></li>
<li>projectmanagers/custom-buildsystem/kcm_custombuildsystem.h <span style="color: grey">(36d9251e718509ce0e174052dd7f4798fb3ee5c6)</span></li>
<li>projectmanagers/custom-buildsystem/kcm_custombuildsystem.cpp <span style="color: grey">(7f03fd700795dfc402cde2fbd243494fc158164a)</span></li>
<li>projectmanagers/custom-buildsystem/kcm_kdevcustombuildsystem.desktop.cmake <span style="color: grey">(60c626ee7e0f4584ced8e4385e1a62b67d40d39b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121074/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>